fixes issues with super->sub-class auto-cast and handles MultiInputObj coercion

tclose commented 2 months ago

Types of changes

Bug fix (non-breaking change which fixes an issue)

Summary

fixes bugs with super->sub-class auto-casting, including when the sub-classes are part of a union. If the super class is a super class of any of the union args then it passes the check.
adds handling for MultiInputObj
streamlines typing error messages

Checklist

[x] I have added tests to cover my changes (if necessary)

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 97.76536% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 88.01%. Comparing base (7d84fba) to head (4c00389). Report is 9 commits behind head on master.

:exclamation: Current head 4c00389 differs from pull request most recent head ad28ae5

Please upload reports for the commit ad28ae5 to get more accurate results.

Files	Patch %	Lines
pydra/utils/typing.py	93.44%	4 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #746 +/- ## =========================================== + Coverage 15.14% 88.01% +72.87% =========================================== Files 53 53 Lines 15693 15817 +124 Branches 2788 1610 -1178 =========================================== + Hits 2376 13922 +11546 + Misses 12988 1893 -11095 + Partials 329 2 -327 ``` | [Flag](https://app.codecov.io/gh/nipype/pydra/pull/746/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipype) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/nipype/pydra/pull/746/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipype) | `88.01% <97.76%> (+72.91%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipype#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tclose commented 1 month ago

NB: the reference hash updates required in the unittests seem be related to changes to the file-hashing process. This could be due to a change in fileformats but I can't remember making any changes that would be related.

tclose commented 1 month ago

@effigies I have parametrized a number of test batches, there a couple more that could probably be done but would require a bit more work so I thought I could leave them for now.

@djarecka if you are busy are you happy to merge if @effigies has been through it? It just cleans up some corner cases that were missed in the original PR

nipype / pydra