nipype / pydra

Pydra Dataflow Engine
https://nipype.github.io/pydra/
Other
119 stars 57 forks source link

ENH: Add more complete format string implementation for argstrings #754

Closed tclose closed 1 month ago

tclose commented 1 month ago

Types of changes

Summary

Adds support for using getitem within argstr formatters, e.g.

"-coord {coord[0]} {coord[1]}..."

Checklist

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 2.63158% with 37 lines in your changes are missing coverage. Please review.

Project coverage is 15.14%. Comparing base (e52e32b) to head (7d84fba). Report is 2 commits behind head on master.

:exclamation: Current head 7d84fba differs from pull request most recent head fc3b31f

Please upload reports for the commit fc3b31f to get more accurate results.

Files Patch % Lines
pydra/engine/tests/test_helpers.py 0.00% 25 Missing :warning:
pydra/engine/helpers.py 7.69% 12 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #754 +/- ## =========================================== - Coverage 84.27% 15.14% -69.14% =========================================== Files 26 53 +27 Lines 5127 15693 +10566 Branches 1447 2788 +1341 =========================================== - Hits 4321 2376 -1945 - Misses 800 12988 +12188 - Partials 6 329 +323 ``` | [Flag](https://app.codecov.io/gh/nipype/pydra/pull/754/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipype) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/nipype/pydra/pull/754/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipype) | `15.10% <2.63%> (-69.18%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nipype#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.