[BUG] Remove pdb breakpoint and make single-op-splits robust to 1d shape

nipype / pydra

Pydra Dataflow Engine

https://nipype.github.io/pydra/

Other

119 stars 57 forks source link

[BUG] Remove pdb breakpoint and make single-op-splits robust to 1d shape #758

Open ibevers opened 3 weeks ago

ibevers commented 3 weeks ago

Types of changes

Bug fix (non-breaking change which fixes an issue)

Summary

Removes a stray pdb breakpoint and makes the splitter functionality robust to 1D inputs for singleton splitters.

Checklist

I will add a test for this case.

[ ] I have added tests to cover my changes (if necessary)
[x] I have updated documentation (if necessary)

effigies commented 3 weeks ago

Thanks! This looks reasonable on first glance. Would you mind creating a test that exercises this edge case?

djarecka commented 3 weeks ago

Hi @ibevers, let me know if you need some help with adding the tests

ibevers commented 3 weeks ago

Hi @ibevers, let me know if you need some help with adding the tests

Hi @djarecka, thank you, I will add them by the end of this week. I have a few other things that I need to take care of first

ibevers commented 2 weeks ago

@djarecka, I spent a while on this, but I was unable to generate a case that triggers if op_single in self.inner_inputs. Would you kindly help me? I think I would need to spend more time than I have reading Pydra source code to know what to do here