search

niqdev / ipcam-view

MJPEG video streaming on Android
https://goo.gl/a2HM8C
MIT License
408 stars 160 forks source link

Support x86_64 #151

Closed hannesa2 closed 2 years ago

niqdev commented 2 years ago

@hannesa2 what are these binary changes exactly? I'm not even sure they're used 🤔

hannesa2 commented 2 years ago

On master you don't supper x86_64 and PlayStore only accept 64 bit only since months

niqdev commented 2 years ago

I haven't touched this project in ages. For history purposes, can you please just reference what step did you do to generate them? Or did you simply run this command? Thanks

hannesa2 commented 2 years ago

In general I only update your repo with the changes of my fork and to be honest I don't remember exactly. Probably I run your build script. But the best way would be not check in this *.so files and let jitpack.io/github build it every time

niqdev commented 2 years ago

Agreed, I'd rather do so. I don't have time to look into it, if you can fix that it would be great! Otherwise, I'll merge it if it's blocking

niqdev commented 2 years ago

But the best way would be not to check in this *.so files and let jitpack.io/github build it every time

@hannesa2 any chance you can fix this? otherwise I'll merge it like that if your are confident with it

hannesa2 commented 2 years ago

I can do it in an other pull request, but I promise nothing

hannesa2 commented 2 years ago

Hold on and wait for #161

niqdev commented 2 years ago

I'll close this one in favour of #161 - Thank you!