search

niqdev / ipcam-view

MJPEG video streaming on Android
https://goo.gl/a2HM8C
MIT License
408 stars 160 forks source link

Better error message #167

Closed hannesa2 closed 2 years ago

hannesa2 commented 2 years ago

I wasn't satisfied about a Toast with content Error That's why I tried to improved it and run into a lot of red code lines and see Butterknife ! Sorry, the time of Butterknife is over !

I converted two Activities into Kotlin and use ViewBinding, and at least I improved the Toast message

niqdev commented 2 years ago

That's great!

niqdev commented 2 years ago

I haven't published the app in the store in a while. @hannesa2 Is there a github action to automate that? Ideally every time there is a new tag it should also update the app in the store.

hannesa2 commented 2 years ago

You have to run a gradle task https://github.com/Triple-T/gradle-play-publisher and you should de/encrypt the keystore.

Sorry, for Playstore publish I've no public repo, but I do the keystore handling and publish it to github release https://github.com/hannesa2/mlkit/tree/OneSample/android/signing The other stuff for inspiration is here https://github.com/hannesa2/mlkit/blob/OneSample/.github/workflows/Android-CI-release.yml.

What's publish it to github release ? It's publish release apk without playstore https://github.com/hannesa2/githubAppUpdate

niqdev commented 2 years ago

I've just created a new issue referencing your comment or it will get lost, thanks for the feedback