search

niqdev / ipcam-view

MJPEG video streaming on Android
https://goo.gl/a2HM8C
MIT License
405 stars 159 forks source link

increase maximum frame size to support newer cameras #219

Closed mdeneen closed 1 year ago

mdeneen commented 1 year ago

Increase maximum frame size from 40,000 bytes to 200,000 bytes to support newer high resolution cameras which can produce larger frames.

Without this change in place the parser fails to detect the start and end frame markers if the frame size happens to be larger than 40,000 bytes.

Surely there is a better way of doing this, but this was the easiest way to get around the problem.

niqdev commented 1 year ago

@mdeneen thanks for your contribution! @hannesa2 do you have any feedback? if you give me a 👍🏻 I'm happy to merge it and release a new version

hannesa2 commented 1 year ago

Nothing against this magic number. 👍

Just if someone comes with too much time, he could put right value under res folders, eg.

image

No clue if it makes sense to put that much afford here

mdeneen commented 1 year ago

It would be easy enough to move it into res if that is desired.

niqdev commented 1 year ago

Thanks for the feedback!

niqdev commented 1 year ago

@mdeneen version 2.4.0 is out with all the latest changes, please let me know if that works and it solves your issue, thanks!