search

nir9 / itemslide

JavaScript Touch Carousel Library with Zero Dependencies
https://itemslide.org
MIT License
647 stars 85 forks source link

itemslide updated in order to avoid usage of global scope #22

Closed AlexVvx closed 9 years ago

AlexVvx commented 9 years ago

Hello everyone, could you please review itemslide update? I moved everything from global scope, updated structure a little. May be you will like changes and would like to merge it with master?

nir9 commented 9 years ago

Wow that's a big update, Thanks! I'll go over it soon and if all is good i'll merge.

nir9 commented 9 years ago

Ok so- First of all the new structure is overall really good but just from testing i found lots of problems: First of all looks like the carousel is now aligned left and not centered as it should be. Second the boundaries no longer work properly only on right side. The swipe out doesn't have an animation. Scrolling doesn't work. And it now feels very buggy.

Anyway's as you can see there are a lot of problems- now i like the new structure but i can't merge something that doesn't work properly so if it would've worked like it works now but with a better structure that would be great.