search

nirenjan / libx52

Saitek X52/X52pro drivers & controller mapping software for Linux
https://nirenjan.github.io/libx52
GNU General Public License v2.0
115 stars 14 forks source link

Default log is too verbose #38

Closed lbeltrame closed 3 years ago

lbeltrame commented 3 years ago

Describe the bug When I don't have my X52 connected, the journalctl logs are spammed with

ott 01 22:57:58 leon.lan x52d[910]: TRACE: x52d_device.c:37 Attempting to connect to X52 device
ott 01 22:57:58 leon.lan x52d[910]: TRACE: x52d_device.c:44 No compatible X52 device found
ott 01 22:57:58 leon.lan x52d[910]: TRACE: x52d_device.c:46 Sleeping for 5 seconds before trying to acquire device again
ott 01 22:57:58 leon.lan x52d[910]: TRACE: x52d_io.c:58 Device disconnected, trying to connect
ott 01 22:57:58 leon.lan x52d[910]: TRACE: x52d_io.c:65 No compatible X52 I/O device found. Sleeping 5 seconds before trying again.

I haven't found a way to disable this logging.

To Reproduce Steps to reproduce the behavior:

  1. Run the daemon without a joystick attached

Expected behavior No TRACE logs unless explicitly enabled.

nirenjan commented 3 years ago

I thought I had disabled that. Please edit /lib/systemd/system/x52d.service, and remove the -vvv from the ExecStart line.

On Fri, Oct 1, 2021, 14:01 Luca Beltrame @.***> wrote:

Describe the bug When I don't have my X52 connected, the journalctl logs are spammed with

ott 01 22:57:58 leon.lan x52d[910]: TRACE: x52d_device.c:37 Attempting to connect to X52 device ott 01 22:57:58 leon.lan x52d[910]: TRACE: x52d_device.c:44 No compatible X52 device found ott 01 22:57:58 leon.lan x52d[910]: TRACE: x52d_device.c:46 Sleeping for 5 seconds before trying to acquire device again ott 01 22:57:58 leon.lan x52d[910]: TRACE: x52d_io.c:58 Device disconnected, trying to connect ott 01 22:57:58 leon.lan x52d[910]: TRACE: x52d_io.c:65 No compatible X52 I/O device found. Sleeping 5 seconds before trying again.

I haven't found a way to disable this logging.

To Reproduce Steps to reproduce the behavior:

  1. Run the daemon without a joystick attached

Expected behavior No TRACE logs unless explicitly enabled.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nirenjan/libx52/issues/38, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJMV6LID3PZEMQ46WGX5YDUEYOSVANCNFSM5FFPXD2Q .

nirenjan commented 3 years ago

I've pushed a fix to the master branch. Please pull from the tip of master.

lbeltrame commented 3 years ago

Whoops, sorry. I had actually tested your suggestion but forgot to get back to you (and of course, it worked). Thanks!