search

nirizr / rematch

REmatch, a complete binary diffing framework that is free and strives to be open source and community driven.
GNU General Public License v3.0
154 stars 22 forks source link

Matching tasks should have a timeout. #300

Open shiftre opened 7 years ago

shiftre commented 7 years ago

In case we get no reply from the server, (for any reason), matching tasks should have a timeout.

Currently, we have to manually kill the IDA in order to stop the task.

nirizr commented 7 years ago

In case of no reply from the server, task progress periodic check will get an error and stop.

On Sun, Jun 11, 2017, 06:06 Shift notifications@github.com wrote:

In case we get no reply from the server, (for any reason), matching tasks should have a timeout.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nirizr/rematch/issues/300, or mute the thread https://github.com/notifications/unsubscribe-auth/ADdqV2EI75RDKwEUmZYbgOv5zo5j8sMSks5sC-YsgaJpZM4N2Y10 .

shiftre commented 7 years ago

It doesn't happen, IDA halts, blocks, and I have to kill it manually.

nirizr commented 7 years ago

Can you write steps to reproduce?

On Sun, Jun 11, 2017, 06:28 Shift notifications@github.com wrote:

It doesn't occur, IDA halts.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/nirizr/rematch/issues/300#issuecomment-307629096, or mute the thread https://github.com/notifications/unsubscribe-auth/ADdqV665icQrI8UppA3UrdPcIzFwzSMJks5sC-togaJpZM4N2Y10 .

shiftre commented 7 years ago
  1. Open IDA 6.95.
  2. Add a new project.
  3. Click the "Match" dialog, (and make sure you're logged in and the server && celery tasks are up).
  4. Either pick a function or the whole project to diff.
  5. Click diff.

Expected result: IDA will hang with a dialog mentioning "Please do not make any ground breaking changes" but since it is blocking it not possible to kill the dialog or the task.