search

nirmata / kyverno-aws-adapter

An adapter for Amazon EKS to use with Kyverno for making policy decisions
Apache License 2.0
11 stars 5 forks source link

Remove imagepullsecret after open sourcing #31

Closed pns-nirmata closed 1 year ago

pns-nirmata commented 1 year ago

Since the repo is open source, we don't need imagepull secrets.

Fixes #30

eddycharly commented 1 year ago

Some users will mirror the image on a private repo though.

anusha94 commented 1 year ago

Some users will mirror the image on a private repo though.

That's a good use case. Then can we add that appropriate comment for the field?

Something like "registry credentials if pulling from your private repository" ?

eddycharly commented 1 year ago

Some users will mirror the image on a private repo though.

That's a good use case. Then can we add that appropriate comment for the field?

Something like "registry credentials if pulling from your private repository" ?

We should introduce imagePullSecrets as a value, users won't put the credentials in clear text here. They will want to reference an existing secret in the cluster (bring your own image pull secret ;-)

anusha94 commented 1 year ago

bring your own image pull secret

@eddycharly Love it!

Let's open a new issue for it and address it separately. We can go ahead with removing this IMO.

eddycharly commented 1 year ago

Yeah, this is trivial to add.

eddycharly commented 1 year ago

@anusha94 see https://github.com/nirmata/kyverno-aws-adapter/pull/33

anusha94 commented 1 year ago

I think we can close this PR in favor of #33

pns-nirmata commented 1 year ago

Closing this PR in favour of #33