search

nirnanaaa / gollum_rails

Integrate Gollum wiki into your Rails app. Continued
GNU Affero General Public License v3.0
43 stars 21 forks source link

Updating dependencies for Rails4? #28

Closed cstromblad closed 9 years ago

cstromblad commented 9 years ago

Hi,

I'm complete newbie when it comes to Rails-development, so bare with me. I was wondering if there is any work going for updating gollum-rails for use with Rails4?

/ Christoffer

PS: Oh, and let me know if there's anything I can do to help...!

nirnanaaa commented 9 years ago

Hi,

GollumRails is already fully compatible with rails 4. the dependency says >= 3.1.16 but does not specify an upper end. It is well tested with rails 4 as well. the latest version (1.6.3 or 1.6.4 on 11/03/14) are definitely working with rails 4.

Please have a look at https://github.com/nirnanaaa/GollumRailsTest41 for a working example. To see a more practical use you can check out my redmine plugin, which is rails 3 but also works seamlessly with rails 4:

https://github.com/nirnanaaa/gollum_redmine/blob/master/app/controllers/pages_controller.rb

Hope I could help you.

cstromblad commented 9 years ago

Hi,

Thanks for the quick reply. I did get it working, I was using rails 4.2.0.beta4 and that had some dependencies that apparently wasn't liked.

Using 4.1.7 (and 4.1.4) everything worked just fine. It was a dependency problem concerning mime-types for the gitlab-grit gem.

Guess that what I get for using beta-gems!

/ Christoffer

nirnanaaa commented 9 years ago

Maybe I can patch that or at least check where it is originated. Can you post your bundle error, please?

cstromblad commented 9 years ago

Bundler could not find compatible versions for gem "mime-types":

        In Gemfile:
          gollum_rails (>= 0) ruby depends on
            gollum-lib (~> 1.0.9) ruby depends on
              gitlab-grit (= 2.6.0) ruby depends on
                mime-types (~> 1.15) ruby

          rails (= 4.2.0.beta4) ruby depends on
            actionmailer (= 4.2.0.beta4) ruby depends on
              mail (>= 2.5.4, ~> 2.5) ruby depends on
                mime-types (2.4.3)

Bundler could not find compatible versions for gem "activemodel":

        In Gemfile:
          gollum_rails (>= 0) ruby depends on
            activemodel (~> 3.2.11) ruby

          rails (= 4.2.0.beta4) ruby depends on
            activemodel (4.2.0.beta4)
nirnanaaa commented 9 years ago

Currently testing with 4.2.2. All tests passing. Seems good. Have a look at version 1.6.4 with updated deps.

nirnanaaa commented 9 years ago

1.6.5 should have fixed the tests for 4.2.0 on travis.