Compatibility issue with Python 3.7 - Githubissues

nirum-lang / nirum-python

The Nirum runtime library for Python

https://nirum.org/docs/target/python.html

MIT License

8 stars 9 forks source link

Compatibility issue with Python 3.7 #117

Open AiOO opened 5 years ago

AiOO commented 5 years ago

(This is not the same issue with as #116)

Since the typing module in Python 3.7 doesn't have _Union class, AttributeError occurs by below lines. To support Python 3.7 it should be fixed.

https://github.com/nirum-lang/nirum-python/blob/2f85525a15f90b16c38650f0110d7a328d67ae79/nirum/_compat.py#L28-L43

p.s. @kanghyojun Could you explain why you used _Union instead of Union?

Relative links

python/typing#283: Removed UnionMeta and added _Union and Union
python/cpython#4906: Removed _Union. Union is now using the new class _SpecialForm.

kanghyojun commented 5 years ago

It seems need to be fixed. But from 0.5.0, nirum-python nearly used for Python target. So why don't you re-create target package on new nirum compiler(0.5.0+).