Closed andli closed 6 years ago
Hello @andli! Thanks for updating the PR.
In the file tableprint/printer.py
, following are the PEP8 issues :
Line 23:80: E501 line too long (101 > 79 characters) Line 31:80: E501 line too long (87 > 79 characters) Line 37:80: E501 line too long (81 > 79 characters) Line 73:80: E501 line too long (89 > 79 characters) Line 82:80: E501 line too long (93 > 79 characters) Line 94:80: E501 line too long (90 > 79 characters) Line 142:80: E501 line too long (97 > 79 characters) Line 161:80: E501 line too long (98 > 79 characters) Line 167:80: E501 line too long (94 > 79 characters) Line 180:80: E501 line too long (83 > 79 characters) Line 199:80: E501 line too long (93 > 79 characters) Line 220:80: E501 line too long (83 > 79 characters) Line 229:80: E501 line too long (82 > 79 characters)
In the file tableprint/utils.py
, following are the PEP8 issues :
Line 34:80: E501 line too long (85 > 79 characters)
There are no PEP8 issues in the file tests/test_functions.py
!
In the file tests/test_io.py
, following are the PEP8 issues :
Line 14:80: E501 line too long (196 > 79 characters) Line 21:80: E501 line too long (196 > 79 characters) Line 22:1: W293 blank line contains whitespace Line 25:80: E501 line too long (142 > 79 characters) Line 29:80: E501 line too long (109 > 79 characters) Line 34:31: E231 missing whitespace after ',' Line 34:42: E231 missing whitespace after ',' Line 34:53: E231 missing whitespace after ',' Line 37:80: E501 line too long (124 > 79 characters)
Merging #15 into master will not change coverage. The diff coverage is
100%
.
@@ Coverage Diff @@
## master #15 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 134 141 +7
=====================================
+ Hits 134 141 +7
Impacted Files | Coverage Δ | |
---|---|---|
tableprint/printer.py | 100% <100%> (ø) |
:arrow_up: |
tableprint/utils.py | 100% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 0e658c0...8df1564. Read the comment docs.
Added unit tests, for science.
I had a look at this, but after working on it I felt that I was refactoring too much of "your" code and I think I respectfully withdraw. Specifically, I started moving the mapdata
subfunction into utils.py
since I think something like that is needed. I suspect you already have a better idea of how that refactoring is best handled.
I added this feature since I need it myself. I tried to match your code style and quality. I have also performed functional testing outside the source.
Hope you like the PR. :)