nirum / tableprint

Pretty console printing :clipboard: of tabular data in python :snake:

https://tableprint.readthedocs.io/

MIT License

174 stars 16 forks source link

Added paddings for tables with the 'round' style #7

Closed itdxer closed 6 years ago

itdxer commented 6 years ago

I think that with padding table looks better

Without padding: table without padding

With padding: table with padding

pep8speaks commented 6 years ago

Hello @itdxer! Thanks for updating the PR.

In the file tests/test_io.py, following are the PEP8 issues :

Line 14:80: E501 line too long (196 > 79 characters) Line 21:80: E501 line too long (196 > 79 characters) Line 25:80: E501 line too long (109 > 79 characters) Line 43:80: E501 line too long (124 > 79 characters)

codecov-io commented 6 years ago

Codecov Report

Merging #7 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff          @@
##           master     #7   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines         135    135           
=====================================
  Hits          135    135

Impacted Files	Coverage Δ
tableprint/style.py	`100% <ø> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8ea9073...b659c61. Read the comment docs.

nirum commented 6 years ago

Hey, looks fantastic! Thanks for the PR!

itdxer commented 6 years ago

@nirum I was wondering if you have any plans to make new release for your library? I do wan't to include fresh version into my project. Right now, I use the last available version 0.7.0 with small hack that allow me to use different style for round.

nirum commented 6 years ago

no problem, I just uploaded v0.7.1: https://pypi.python.org/pypi/tableprint

itdxer commented 6 years ago

awesome! thank you @nirum