Closed nirum closed 6 years ago
Hello @nirum! Thanks for submitting the PR.
setup.py
, following are the PEP8 issues :Line 6:80: E501 line too long (85 > 79 characters) Line 22:80: E501 line too long (82 > 79 characters) Line 23:80: E501 line too long (89 > 79 characters) Line 56:80: E501 line too long (80 > 79 characters) Line 62:80: E501 line too long (82 > 79 characters)
tableprint/printer.py
, following are the PEP8 issues :Line 23:80: E501 line too long (101 > 79 characters) Line 31:80: E501 line too long (87 > 79 characters) Line 37:80: E501 line too long (81 > 79 characters) Line 73:80: E501 line too long (89 > 79 characters) Line 82:80: E501 line too long (93 > 79 characters) Line 94:80: E501 line too long (90 > 79 characters) Line 139:80: E501 line too long (97 > 79 characters) Line 158:80: E501 line too long (98 > 79 characters) Line 164:80: E501 line too long (94 > 79 characters) Line 177:80: E501 line too long (83 > 79 characters) Line 196:80: E501 line too long (93 > 79 characters) Line 217:80: E501 line too long (83 > 79 characters) Line 226:80: E501 line too long (82 > 79 characters)
tableprint/utils.py
, following are the PEP8 issues :Line 34:80: E501 line too long (85 > 79 characters)
tests/test_io.py
, following are the PEP8 issues :Line 14:80: E501 line too long (196 > 79 characters) Line 21:80: E501 line too long (196 > 79 characters) Line 25:80: E501 line too long (109 > 79 characters) Line 30:31: E231 missing whitespace after ',' Line 30:42: E231 missing whitespace after ',' Line 30:53: E231 missing whitespace after ',' Line 33:80: E501 line too long (124 > 79 characters)
Merging #9 into master will not change coverage. The diff coverage is
100%
.
@@ Coverage Diff @@
## master #9 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 135 134 -1
=====================================
- Hits 135 134 -1
Impacted Files | Coverage Δ | |
---|---|---|
tableprint/printer.py | 100% <100%> (ø) |
:arrow_up: |
tableprint/utils.py | 100% <100%> (ø) |
:arrow_up: |
tableprint/metadata.py | 100% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update bbee3a7...c2d1ea7. Read the comment docs.
As pointed out in issue #8, requiring numpy as a dependency is unnecessary for such a lightweight utility.
This PR replaces the two places where numpy was used:
np.floor
tomath.floor
when rounding, and