search

niryariv / opentaba-client

BSD 3-Clause "New" or "Revised" License
8 stars 15 forks source link

Issue 64 - allow linking directly to plan #103

Closed florpor closed 9 years ago

florpor commented 9 years ago

and this is what it looks like: plan-highlight

niryariv commented 9 years ago
  1. i cant get it to work locally. am i missing something?
  2. please add an anchor on each plan, so if it's in the URL the right pane scrolls to that plan

screen shot 2014-12-05 at 3 33 04 pm

florpor commented 9 years ago

mmm are there any errors in your console? there's already a scroll animation trying to position the plan in the middle of the window

niryariv commented 9 years ago

no console errors. i suspect it has to do with the path argument..

On Fri, Dec 5, 2014 at 4:43 PM, florpor notifications@github.com wrote:

mmm are there any errors in your console? there's already a scroll animation trying to position the plan in the middle of the window

— Reply to this email directly or view it on GitHub https://github.com/niryariv/opentaba-client/pull/103#issuecomment-65798426 .

florpor commented 9 years ago

looks loke it.. could you log the plan_id parameter there and see if it's set correctly? or are you planning to come this monday?

niryariv commented 9 years ago

it is working now - but it seems like some of the plans it just scrolls to the top of the page instead of the plan, maybe this caused the issue. why not simply use anchors?

On Fri, Dec 5, 2014 at 5:57 PM, florpor notifications@github.com wrote:

looks loke it.. could you log the plan_id parameter there and see if it's set correctly? or are you planning to come this monday?

— Reply to this email directly or view it on GitHub https://github.com/niryariv/opentaba-client/pull/103#issuecomment-65809410 .

niryariv commented 9 years ago

merged manually