email notifier service (beta)

niryariv / opentaba-client

BSD 3-Clause "New" or "Revised" License

8 stars 15 forks source link

email notifier service (beta) #110

Closed noamoss closed 8 years ago

alonisser commented 8 years ago

Ok looks good, But please explain more:

What is notifier service, yours? public ? something else?
Does the user needs to authenticate in some way? does the system "remember" his email or does he have to enter it everytime?

noamoss commented 8 years ago

@alonisser

It is something we build to enable (regular) users to recieve costumized updates from Eknights. (read more here
For now user needs to supply email+password. I hope to change to no password login soon. Found this, but not sure yet about the implementation.

niryariv commented 8 years ago

@noamoss

I tested locally, getting an error from the server. It might be due to inaccessible URL in the parameters: http://82.196.4.213/addfeed/opentaba?city=%D7%99%D7%A8%D7%95%D7%A9%D7%9C%D7%99%D7%9D&link=http://0.0.0.0:5000//plans.atom

(also note extra / before /plans.atom)

The URL should be real domain name, not IP address - it makes it look like some phishing site.

noamoss commented 8 years ago

fixed (see below). I will repush the fix once the notifier server will be up again.

niryariv commented 8 years ago

looks good, I like the new icon

alonisser commented 8 years ago

+1 for the new icon

On Thu, May 26, 2016 at 12:03 PM Nir Yariv notifications@github.com wrote:

looks good, I like the new icon

— You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub https://github.com/niryariv/opentaba-client/pull/110#issuecomment-221816752