Closed florpor closed 8 years ago
@florpor just to be sure this isn't breaking. old links scraped before they added the full url are also handled correctly? or is this issue handled in server?
On Wed, Jun 1, 2016 at 9:48 PM florpor notifications@github.com wrote:
Merged #112 https://github.com/niryariv/opentaba-client/pull/112.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/niryariv/opentaba-client/pull/112#event-678852029, or mute the thread https://github.com/notifications/unsubscribe/ABXlcPoHzaMr3FGBB9s6R7eJjt0HBP1Wks5qHdPwgaJpZM4Ir2hG .
All links in mmi's site were replaced and scraped so now all files_links are full urls
@florpor I understand this is not deployed yet, right? Still seeing broken Tasrit links in places like http://opentaba.info/#/gush/30082
@alonisser congratulations :) if you have time to get on github, that's a good sign 👍
@niryariv thanks! congratulations to you too :)
On Fri, Jun 3, 2016 at 12:30 PM Nir Yariv notifications@github.com wrote:
@florpor https://github.com/florpor I understand this is not deployed yet, right? Still seeing broken Tasrit links in places like http://opentaba.info/#/gush/30082
@alonisser https://github.com/alonisser congratulations :) if you have time to get on github, that's a good sign 👍
— You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/niryariv/opentaba-client/pull/112#issuecomment-223533856, or mute the thread https://github.com/notifications/unsubscribe/ABXlcEmBEFDFitLN8VAuxVTOWKiC5Lvmks5qH_QrgaJpZM4Ir2hG .
@niryariv just finished deploying
Don't prepend base mmi url as they began providing a full url (this fixes the mamag links which were prepended with the domain name as part of the plan template and not while scraping).