fix top-right icons order

niryariv / opentaba-client

BSD 3-Clause "New" or "Revised" License

8 stars 15 forks source link

fix top-right icons order #115

Closed noamoss closed 7 years ago

noamoss commented 8 years ago

elegant soultion to icons order issue

florpor commented 8 years ago

Looks better since notifier and forum links are always there and fb and twitter aren't, but still if there isn't a fb page but there is a twitter one it will still look weird (twitter one will be one empty space away from the forum link).. Can you maybe also change the way these icons are hidden and shown to use the "display" css property so that when they are hidden (display: none) they will not take any space?

noamoss commented 8 years ago

@niryariv ??

niryariv commented 8 years ago

@noamoss what's the status? did u fix per @florpor's comment?

niryariv commented 8 years ago

unless I'm missing something it's the same ?

noamoss commented 7 years ago

@niryariv fixed on: https://github.com/niryariv/opentaba-client/commit/3a2b06c4467f00035d80340473ec5699ee01bd0b