search

niryariv / opentaba-client

BSD 3-Clause "New" or "Revised" License
8 stars 15 forks source link

subdomain cities and combo picker #34

Open florpor opened 10 years ago

alonisser commented 10 years ago

@florpor @niryariv

  1. @niryariv Can we merge this before we have the Vaad decision?
  2. @florpor The tests are failing because of this change:

-

So when we do merge this (see 1) please change the test_index.js accordingly. to search for cities.js It also seems that I should write a new test for this intermediate step of fetching the gushim for a specific city, @florpor could you write me the Exact sequence we should test for?

  1. @florpor while at it, can you also fix heroku api address to use https? and close #31
niryariv commented 10 years ago

we're holding on the merge until the vaad decides (in any case we'll need to add one city at a time initially, to see how the db handles etc)

that gives us some time to fix the tests :)

i'll handle #31 meanwhile

florpor commented 10 years ago

@alonisser i fixed the test to test against the default city. to load a different city you have to browse an address that starts with the city's name (ie. ramatgan.localhost). can travis-ci run the casperjs tests against the actual published site? or does it run them against a local file like when i run casperjs locally? if a subdomain was requested, it checks it against the values in cities.js and if it does not exist it takes 'jerusalem' from cities.js. from the file it reads the display name (i added a test for that, jerusalem only), heroku address, map center point and json file, then loads the file and adds the gushim layer to the map. i changed the heroku addresses that i have to https just in case.

@niryariv we can merge it even if we want to add one city at a time, just removeall others from cities.js and don't register other subdomains.

florpor commented 10 years ago

fixed a bug i had... i'd really appreciate it if someone who knows js could go over these changes.. i'm not experienced with this at all and i'm not sure i'm writing good code...

alonisser commented 10 years ago

I'll try towards weekend.. also, run jshint on your code, would help to detect some problems with js good practices

alonisser commented 10 years ago

currently casperjs tests against a clean local site built on travis ci and destroyed after the test ends. this is the point of a ci.. we could program it to run against the actuall published site, but I wouldn't do it from the CI server, you can change the url in the test scripts to run the tests against the deployed site, if you want another sanity test. next monday I'll go over the tests and check them including the multiple site option. I would also check the js

Twitter:@alonisser https://twitter.com/alonisser LinkedIn Profile http://www.linkedin.com/in/alonisser Facebook https://www.facebook.com/alonisser _Tech blog:_4p-tech.co.il/blog _Personal Blog:_degeladom.wordpress.com Tel:972-54-6734469

On Mon, Oct 28, 2013 at 4:17 PM, florpor notifications@github.com wrote:

fixed a bug i had... i'd really appreciate it if someone who knows js could go over these changes.. i'm not experienced with this at all and i'm not sure i'm writing good code...

— Reply to this email directly or view it on GitHubhttps://github.com/niryariv/opentaba-client/pull/34#issuecomment-27214814 .