search

niryariv / opentaba-client

BSD 3-Clause "New" or "Revised" License
8 stars 15 forks source link

Revise the address service #36

Closed alonisser closed 10 years ago

alonisser commented 10 years ago

either rewrite it

or better, just change for some online service that would do the job directly from the client side( google api?)

niryariv commented 10 years ago

The geocoding part should definitely be changed to use Google API instead of Nominatim - based on our experience with Tipa.li, which showed Google to be more accurate.

We'd still need the rest of the code though, since the trickier part is finding which gush the coordinates are inside.

Basically I think we should fork https://github.com/giladgo/opentaba-address-db, change it to use Google Maps API and push it on a new Heroku server which we can manage. While we're at it we might add some ping service like uptimerobot.com to keep the Heroku dynos working and avoid delays.

florpor commented 10 years ago

Why do we need the address server? How about we make a request to google api using javascript, then use a library like https://github.com/mapbox/leaflet-pip to query the layer json directly for polygons containing the point? (assuming it works well of course, haven't tested it yet)

niryariv commented 10 years ago

cool - wasn't aware of this lib. we should definitely look into it, if it works well it's definitely a better solution.

florpor commented 10 years ago

opened a branch on my repo so you can see it working if you want (seems to be working nice and fast): https://github.com/florpor/opentaba-client/tree/googleapi the relevant commit is: https://github.com/florpor/opentaba-client/commit/3d7e5d2e96181267cd9533c2ccac8a09d8b4f0d6

the only thing is, i tried to get it to only search the current loaded city (which goes well with the text on top of the search box). if we want something a bit more sophisticated we should talk about how to implement it.

florpor commented 10 years ago

code merged: https://github.com/niryariv/opentaba-client/commit/52209d03faf6afa0ef92bfda89ad01c8ae84aed0

if anyone sees this, please search for an address and make sure it works...

alonisser commented 10 years ago

checked it now, looks greet, lucky for us that the damm coors problem was only in chrome localhost and not in production

alonisser commented 10 years ago

great

Twitter:@alonisser https://twitter.com/alonisser LinkedIn Profile http://www.linkedin.com/in/alonisser Facebook https://www.facebook.com/alonisser _Tech blog:_4p-tech.co.il/blog _Personal Blog:_degeladom.wordpress.com Tel:972-54-6734469

On Tue, Nov 5, 2013 at 11:35 PM, florpor notifications@github.com wrote:

Closed #36 https://github.com/niryariv/opentaba-client/issues/36.

— Reply to this email directly or view it on GitHubhttps://github.com/niryariv/opentaba-client/issues/36 .

niryariv commented 10 years ago

merged with gh-pages, pushed to the live site