search

niryariv / opentaba-client

BSD 3-Clause "New" or "Revised" License
8 stars 15 forks source link

Major folder regorganization, Automatic build and deploy to gh-pages, Fixed some of the testing #51

Open alonisser opened 10 years ago

alonisser commented 10 years ago

please review this, this isn't minor

major changes:

all app development is contained in app folder various build and dev tasks: such as: grunt serve for local dev (with livereload), grunt build to create a minfied, revvyed, concated, optimized, cleaned from console.log etc.. dist folder and automatic deploy to gh-pages (also an option for build without deploy)

Updated readme with instructions for usage and setup

most tests fixed (not all yet) to use updated casperjs version

florpor commented 10 years ago

Sorry it took me so long to look at this, but it looks great! Had a bit of a hard time configuring, mostly cuz i had no idea what gruntjs and bower were, but it's not actually hard. Should add "npm install -g bower" to .travis.yml to get travis to not error out. Great stuff

alonisser commented 10 years ago

I'll fix travis.. thanks @florpor

Twitter:@alonisser https://twitter.com/alonisser LinkedIn Profile http://www.linkedin.com/in/alonisser Facebook https://www.facebook.com/alonisser _Tech blog:_4p-tech.co.il/blog _Personal Blog:_degeladom.wordpress.com Tel:972-54-6734469

On Mon, Feb 3, 2014 at 12:34 PM, florpor notifications@github.com wrote:

Sorry it took me so long to look at this, but it looks great! Had a bit of a hard time configuring, mostly cuz i had no idea what gruntjs and bower were, but it's not actually hard. Should add "npm install -g bower" to .travis.yml to get travis to not error out. Great stuff

Reply to this email directly or view it on GitHubhttps://github.com/niryariv/opentaba-client/pull/51#issuecomment-33939754 .

niryariv commented 10 years ago

sorry it's taking me so long, been swamped at work/home. i still havent managed to get this running - i expect it's a noob question, but i get this:

niryariv$ grunt build
Loading "Gruntfile.js" tasks...ERROR
>> Error: Cannot find module 'load-grunt-tasks'
Warning: Task "build" not found. Use --force to continue.

Aborted due to warnings.
florpor commented 10 years ago

@niryariv do a 'npm install' in the folder to install prerequisites listed in package.json

alonisser commented 10 years ago

Any news on this? sepcific problems?

niryariv commented 10 years ago

Yeah, I wanted to discuss this with you when we meet but it doesn't seem to work out :)

I like the code, but concerned that it makes the learning curve steeper - much of the contributions on the client side were done by people who put in a couple hours' CSS or JS work. This requires setting up npm/grunt/bower just in order to build the code locally, so makes it harder to contribute new patches.

I realize this is the right way to go in the long run, but since the client side is so small at this stage and so easy to build (just opening index.html in a browser works, without even running a local server), I think it'll be better to keep it simple at this point.

That said I'm open to hear contradicting opinions from everyone: @alonisser @florpor @shevron @Oreniko let me know what you think..

alonisser commented 10 years ago

I think every serious front end developer ourdays work with this kind of tools on a daily basis. I can setup instructions in the readme for that. I believe that later is harder and we should start adopting good practices in our (going to be) growing open source project. besides,. without npm install, grunt, etc the commiter cant run the tests locally.. and we sure want them to do so..

Twitter:@alonisser https://twitter.com/alonisser LinkedIn Profile http://www.linkedin.com/in/alonisser Facebook https://www.facebook.com/alonisser _Tech blog:_4p-tech.co.il/blog _Personal Blog:_degeladom.wordpress.com Tel:972-54-6734469

On Wed, Mar 26, 2014 at 3:53 PM, Nir Yariv notifications@github.com wrote:

Yeah, I wanted to discuss this with you when we meet but it doesn't seem to work out :)

I like the code, but concerned that it makes the learning curve steeper - much of the contributions on the client side were done by people who put in a couple hours' CSS or JS work. This requires setting up npm/grunt/bower just in order to build the code locally, so makes it harder to contribute new patches.

I realize this is the right way to go in the long run, but since the client side is so small at this stage and so easy to build (just opening index.html in a browser works, without even running a local server), I think it'll be better to keep it simple at this point.

That said I'm open to hear contradicting opinions from everyone: @alonisser https://github.com/alonisser @florporhttps://github.com/florpor @shevron https://github.com/shevron @Orenikohttps://github.com/Orenikolet me know what you think..

Reply to this email directly or view it on GitHubhttps://github.com/niryariv/opentaba-client/pull/51#issuecomment-38685363 .