search

niryariv / opentaba-client

BSD 3-Clause "New" or "Revised" License
8 stars 15 forks source link

look into TopoJSON #59

Closed niryariv closed 10 years ago

niryariv commented 10 years ago

TopoJSON is an extension of GeoJSON which reduces file size significantly (in some tests I ran on large GeoJSON files, the Topo equivalent was about %10 of the original)

It's easy to use with Leaflet.js: http://bl.ocks.org/JasonSanford/4554134

florpor commented 10 years ago

implemented in the topojson branch: https://github.com/niryariv/opentaba-client/tree/topojson it is pretty good sizewise vs geojson (to be fair, i also just figured out i can get rid of the properties dictionary in favor of just an id field, but still..). only one file in the gushim folder is over 1mb in its topojson form.

@niryariv want to merge?

niryariv commented 10 years ago

yalla merge

florpor commented 10 years ago

done. closing. all hail topojson.

niryariv commented 10 years ago

still using geojson in the code though, no? topos are only on master..

florpor commented 10 years ago

ah yes sorry, only merged into master and forgot about gh-pages. did it now.

niryariv commented 10 years ago

we still need to actually use the topo in the app.js code - but i guess that could be done with https://github.com/niryariv/opentaba-server/issues/71

florpor commented 10 years ago

but it is used: https://github.com/niryariv/opentaba-client/blob/master/app.js#L293 it only took minor changes, only this commit: https://github.com/niryariv/opentaba-client/commit/6f85bd56d1453f7c12f5006ec01f62c31d72ca9b

niryariv commented 10 years ago

cool :)

On Thu, Jul 3, 2014 at 9:21 PM, florpor notifications@github.com wrote:

but it is used: https://github.com/niryariv/opentaba-client/blob/master/app.js#L293 it only took minor changes, only this commit: 6f85bd5 https://github.com/niryariv/opentaba-client/commit/6f85bd56d1453f7c12f5006ec01f62c31d72ca9b

— Reply to this email directly or view it on GitHub https://github.com/niryariv/opentaba-client/issues/59#issuecomment-47966235 .