search

niryariv / opentaba-client

BSD 3-Clause "New" or "Revised" License
8 stars 15 forks source link

add right side margin to mobile_merge #63

Closed niryariv closed 10 years ago

niryariv commented 10 years ago

mobile_merge html removes the margin on the right side, like so:

screen shot 2014-07-30 at 11 41 53 am

compare to opentaba.info: screen shot 2014-07-30 at 11 42 07 am

florpor commented 10 years ago

hmm what browser+os are you using to see this? on my linux both firefox and chromium have some space between the right edge and the text and it looks fine.

niryariv commented 10 years ago

checked with firefox / chrome on a mac

florpor commented 10 years ago

can't say that i can see the same: (taken on a bit of an old mac with chrome) screen shot 2014-07-30 at 1 54 29 pm

are you sure you don't have any settings preventing padding or something? or maybe a scroll bar hiding preventing you from seeing the entire thing?

niryariv commented 10 years ago

are you checking it on the mobile_merge branch?

On Wed, Jul 30, 2014 at 1:59 PM, florpor notifications@github.com wrote:

can't say that i can see the same: (taken on a bit of an old mac with chrome) [image: screen shot 2014-07-30 at 1 54 29 pm] https://cloud.githubusercontent.com/assets/1809093/3748150/6b7d5032-17d8-11e4-87c7-1f5c8c0bfb01.png

are you sure you don't have any settings preventing padding or something? or maybe a scroll bar hiding preventing you from seeing the entire thing?

— Reply to this email directly or view it on GitHub https://github.com/niryariv/opentaba-client/issues/63#issuecomment-50600522 .

florpor commented 10 years ago

yes. and i did set right-padding to 0 while working on it, because without it when in "mobile-mode" there's a white space on the right side of the map.

florpor commented 10 years ago

fixed by @niryariv in https://github.com/niryariv/opentaba-client/commit/963b8cd8a86b9778bf129fa2c79cdf157cf5d6f5