niryariv / opentaba-client

BSD 3-Clause "New" or "Revised" License
8 stars 15 forks source link

test new approach for client sites #71

Closed niryariv closed 9 years ago

niryariv commented 10 years ago

pull instead of push, auto-merge

florpor commented 10 years ago

coded here: https://github.com/niryariv/opentaba-server/commit/c788d5ea1f10b963673406a4c766984da92893a5

it works as expected, auto merge and quick. downside is the need to maintain local repositories for every municipality you want to deploy updates to.

@niryariv what do you think?

niryariv commented 9 years ago

@florpor am I using the wrong client repo (niryariv/opentaba-client)?

localhost:opentaba-server niryariv$ fab create_client:eilat,"אילת"
Github user: niryariv
Github password:
[localhost] local: git checkout master
Already on 'master'
Your branch is ahead of 'origin/master' by 303 commits.
  (use "git push" to publish your local commits)
[localhost] local: git add data/index.js
[localhost] local: git commit -m "added eilat to index.js"
On branch master
Your branch is ahead of 'origin/master' by 303 commits.
  (use "git push" to publish your local commits)

nothing to commit, working directory clean

Fatal error: local() encountered an error (return code 1) while executing 'git commit -m "added eilat to index.js"'

Aborting.

where would it create the client repo locally?

florpor commented 9 years ago

the name of the pull tasks are: create_client_pull, delete_client_pull, deploy_client_pull, deploy_client_pull_all

it creates the local repos under ../municipalities/ (from the opentaba-server directory)

niryariv commented 9 years ago

i still don't get it. I tried creating a site with create_client_pull, similar error:

localhost:opentaba-server niryariv$ fab create_client_pull:tveria,"טבריה"
Github user: niryariv
Github password:
[localhost] local: git checkout master
Already on 'master'
Your branch is up-to-date with 'origin/master'.
[localhost] local: git add data/index.js
[localhost] local: git commit -m "added tveria to index.js"
On branch master
Your branch is up-to-date with 'origin/master'.

nothing to commit, working directory clean

Fatal error: local() encountered an error (return code 1) while executing 'git commit -m "added tveria to index.js"'

Aborting.

what's the process for setting up a non-dummy client site?

florpor commented 9 years ago

fixed the error: https://github.com/niryariv/opentaba-server/commit/3fdb06bb3484029105456722936f599f17a94d2e

what do you mean by "process for setting up a non-dummy"? this task does it, and also the push-based create_client