search

niryariv / opentaba-client

BSD 3-Clause "New" or "Revised" License
8 stars 15 forks source link

complete cleanup of codebase #73

Closed niryariv closed 10 years ago

niryariv commented 10 years ago

the repo is still larger than it should be:

Writing objects: 100% (471/471), 12.37 MiB

Must be some leftover gushim maps

alonisser commented 10 years ago

tried git gc?

Twitter:@alonisser https://twitter.com/alonisser LinkedIn Profile http://www.linkedin.com/in/alonisser Facebook https://www.facebook.com/alonisser _Tech blog:_4p-tech.co.il/blog _Personal Blog:_degeladom.wordpress.com Tel:972-54-6734469

On Sun, Sep 14, 2014 at 5:33 PM, Nir Yariv notifications@github.com wrote:

the repo is still larger than it should be:

Writing objects: 100% (471/471), 12.37 MiB

Must be some leftover gushim maps

— Reply to this email directly or view it on GitHub https://github.com/niryariv/opentaba-client/issues/73.

niryariv commented 10 years ago

ran it locally but the difference seems marginal. i think it's probably data/jerusalem.json and maybe some other leftovers in git history

florpor commented 10 years ago

git gc only deletes stuff locally and doesn't change the remote size, no?

anyways, i deleted a few more files. i did not want to delete the contributed files (but i did delete their history), and jerusalem.json is still in use with the version that is currently published on gh-pages, so i'll delete it after we finish using it to avoid confusion. i think 14 mb is fine for the repo - including tests with images, the lib folder, the 3 gushim files (one topojson, one dwg and one zip) and over a year and a half of work. i feel that rewriting history like this is not really for the best and we shouldn't go all out with this...

alonisser commented 10 years ago

Plus one On Sep 15, 2014 11:40 AM, "florpor" notifications@github.com wrote:

git gc only deletes stuff locally and doesn't change the remote size, no?

anyways, i deleted a few more files. i did not want to delete the contributed files (but i did delete their history), and jerusalem.json is still in use with the version that is currently published on gh-pages, so i'll delete it after we finish using it to avoid confusion. i think 14 mb is fine for the repo - including tests with images, the lib folder, the 3 gushim files (one topojson, one dwg and one zip) and over a year and a half of work. i feel that rewriting history like this is not really for the best and we shouldn't go all out with this...

— Reply to this email directly or view it on GitHub https://github.com/niryariv/opentaba-client/issues/73#issuecomment-55564743 .

niryariv commented 10 years ago

i did git gc locally, saw the dir size only changed marginally so assumed it's not the cleanup we're looking for..

localhost:Projects niryariv$ git clone git@github.com:niryariv/opentaba-client.git
Cloning into 'opentaba-client'...
remote: Counting objects: 3137, done.
remote: Compressing objects: 100% (1019/1019), done.
remote: Total 3137 (delta 1602), reused 2858 (delta 1449)
Receiving objects: 100% (3137/3137), 28.53 MiB | 1.24 MiB/s, done.
Resolving deltas: 100% (1602/1602), done.
Checking connectivity... done.
florpor commented 10 years ago

just merged changes into gh-pages branch. add me as collaborator to israel-gushim so i can push the originals. the 28 mb size is because of other branches. after i add originals to your repo i'll do some more deletion work (and you'll need to rebase again).

alonisser commented 10 years ago

I don't understand the problem .. 28MB is perfectly acceptable.

Twitter:@alonisser https://twitter.com/alonisser LinkedIn Profile http://www.linkedin.com/in/alonisser Facebook https://www.facebook.com/alonisser _Tech blog:_4p-tech.co.il/blog _Personal Blog:_degeladom.wordpress.com Tel:972-54-6734469

On Mon, Sep 15, 2014 at 2:19 PM, florpor notifications@github.com wrote:

just merged changes into gh-pages branch. add me as collaborator to israel-gushim so i can push the originals. the 28 mb size is because of other branches. after i add originals to your repo i'll do some more deletion work (and you'll need to rebase again).

— Reply to this email directly or view it on GitHub https://github.com/niryariv/opentaba-client/issues/73#issuecomment-55577568 .

niryariv commented 10 years ago

since we're now creating new repo for each city, it's faster when the repo size is smaller. also, we moved all the gushim maps to https://github.com/niryariv/israel_gushim so no point in keeping them there.

in any case, it's not really a big deal, just housekeeping.