search

niryariv / opentaba-client

BSD 3-Clause "New" or "Revised" License
8 stars 15 forks source link

extend map bounds #82

Closed niryariv closed 9 years ago

niryariv commented 9 years ago

we should extend about 0.5 degree to each direction, both to allow users to find other munis via the muni lables, and also because i suspect it's causing this issue: screen shot 2014-09-26 at 12 09 08 pm screen shot 2014-09-26 at 12 08 59 pm

florpor commented 9 years ago

done, but i only added 0.2 degree padding. it's more than the map size (on my screen) so you can't see your municipality's data at all at the edges. 0.5 is a lot (about 55 km according to the link you sent me once). @niryariv can you try it out and see if the bug's gone, and if it isn't tell me about it so i can see for myself?

commits are: https://github.com/niryariv/opentaba-client/commit/3c26fc5e9c0dc71a230d865e14d4f945239d18d8 and https://github.com/niryariv/opentaba-server/commit/768c97efef4447fdf8e011b9fcebc2fcceac2723

niryariv commented 9 years ago

took a little different approach - muni.js will still keep the real bounds, so we can control via app.js how much we want to extend them. Seems to fix the gush mapping issue too: https://github.com/niryariv/opentaba-client/commit/6447c6dbb6253ed33c6eacf490044f668102daf8

Still not sure regarding the coords in muni.js - I saw they changed and switched back, but not sure if to the correct figures.. @florpor can you see?

florpor commented 9 years ago

they were still with the extra 0.2. reverted now and closing