search

niryariv / tiptipa

Mobile friendly minisite for location nearby Polio vaccination centers in Israel
http://tipa.li/
BSD 3-Clause "New" or "Revised" License
3 stars 5 forks source link

show station beyond "green line" #2

Closed niryariv closed 10 years ago

niryariv commented 10 years ago

No politics - the goal is just to show all the stations that exist, for everyone's benefit.

Currently we use Google API to filter only locations encoded as "Israel" - we should add "Palestine" (or West Bank, or PA - whatever Google uses) so that these stations will show too.

@alonisser, seems to like it's just changing

return i['long_name']=='Israel'

to

return (i['long_name']=='Israel' or i['long_name']=='Palestinian Authority') ?

alonisser commented 10 years ago

Should work. I didn't check errors.txt to find the exact term used in Google api if it's Palestine? or palestinian authority or whatever.. You'll run it again? I'm gonna double check the original json to check If I can automaticaly solve the stations under other stations problems (Like the one in Azur)

niryariv commented 10 years ago

fixed, at least partly - Modiin Illit shows, but not Kiryat Arba

niryariv commented 10 years ago

now fixed completely - turns out that google geocoding returns settlements without country param, ie neither Israel or Palestine: https://github.com/niryariv/tiptipa/commit/1d56a438f9e10ed74bb39e627501ff97ee978e60#L2L38

alonisser commented 10 years ago

@niryariv great!