search

nisar-solid / ATBD

Notebooks for NISAR Solid Earth Algorithm Theoretical Basis Document
35 stars 22 forks source link

Updated Coseismic and Secular NISAR Validation notebooks #22

Closed mgovorcin closed 2 years ago

review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

review-notebook-app[bot] commented 2 years ago

View / edit / reply to this conversation on ReviewNB

dbekaert commented on 2022-04-22T02:33:15Z ----------------------------------------------------------------

Line #1.    do_tropo_correction = True

Should this not be set to False by Default?


_mgovorcin commented on 2022-04-22T02:49:47Z_ ----------------------------------------------------------------

yes, I will set it False

review-notebook-app[bot] commented 2 years ago

View / edit / reply to this conversation on ReviewNB

dbekaert commented on 2022-04-22T02:33:15Z ----------------------------------------------------------------

The list of stations that came from the old and new notebook is not a 1-1 match. We should check as to why.


mgovorcin commented on 2022-04-22T04:27:26Z ----------------------------------------------------------------

this changes when I change the ts end date to 20190101, together with other results

review-notebook-app[bot] commented 2 years ago

View / edit / reply to this conversation on ReviewNB

dbekaert commented on 2022-04-22T02:33:16Z ----------------------------------------------------------------

Line #34.                'download_end_date' : '20180801',

This is conssitent with the original notebook from Adrian. But for some reasons his output in the cells and his plots in the old notebook go beyond 2019. We need to check if he ran the notebook and changed the end-date intentionally or if we need to stage more data.


dbekaert commented 2 years ago

Reached out to Adrian and CC-ed you to confirm some of the parameters.

mgovorcin commented 2 years ago

yes, I will set it False

View entire conversation on ReviewNB

mgovorcin commented 2 years ago

this changes when I change the ts end date to 20190101, together with other results

View entire conversation on ReviewNB

  • © Githubissues.
  • Githubissues is a development platform for aggregating issues.