search

nisar-solid / ATBD

Notebooks for NISAR Solid Earth Algorithm Theoretical Basis Document
33 stars 22 forks source link

Move sampling code to a python file from transient notebook for other validation approaches #23

Closed kanglcn closed 2 years ago

kanglcn commented 2 years ago

I have moved the sampling code to ATBD/solid_utils/sampling.py. It includes several functions to calculate local coordinates for products, make sampling, and pair them up. The detailed usage is written in the docstrings.

Also, I decrease the number of products downloaded by using --daysless and --daysmore options in ariaDownload.py. And I am using three years of products now.

review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

kanglcn commented 2 years ago

Sorry I forget to remove several code cells that I used to test the pickle file interface for Adrian. I will make a new commit to remove them.

yunjunz commented 2 years ago

The *.ipynb file naming is currently not consistent between different requirements. I like the one from Adrian as NISAR_SES_Secular_Requirement_Validation.ipynb, shall we enforce all three requirements notebook having the same naming convention? @kanglcn @EJFielding @dbekaert

EJFielding commented 2 years ago

I thought that the first part of the notebook name NISAR_SES_ was redundant with the location in the Solid Earth part of the GitLab. I also found that I could not see the useful part of the notebook name in a narrow column with the long name. Once we have the final versions, then the end of the notebook file name is not so important.

yunjunz commented 2 years ago

Shorter names sound even better.

dbekaert commented 2 years ago

Shorter names sound even better.

Yeah i agree. Lets make them consistent with a short name.

kanglcn commented 2 years ago

All, I have made an update according to your comments. Please check if it solves the problems you mentioned. Thanks for your effort. @yunjunz @EJFielding @dbekaert

yunjunz commented 2 years ago

Thank you @kanglcn for the updates. I put a few more minor comments, for the last round I think. Could you also check the style issues flagged by Codacy?

kanglcn commented 2 years ago

Thank you @kanglcn for the updates. I put a few more minor comments, for the last round I think. Could you also check the style issues flagged by Codacy?

Thanks @yunjunz . I will look into them. Thanks for pointing out the Codacy problem. I haven't used it before but I think this shouldn't be a big problem.

kanglcn commented 2 years ago

I have updated under @yunjunz 's suggestions. Please check.

kanglcn commented 2 years ago

Thanks, @yunjunz for helping me fix more codacy issues. I can't find them even with their hints.