Secular: Add Method 2, changed site to MojaveD173

[EJFielding]

Added code to calculate Method 2, added site MojaveD173, and changed to use that for Secular validation

[review-notebook-app[bot]]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[EJFielding]

Note that I left the notebook file name the same as before to make it easier to compare to the previous version in ReviewNB.

[review-notebook-app[bot]]

View / edit / reply to this conversation on ReviewNB

dbekaert commented on 2022-05-23T04:20:50Z ----------------------------------------------------------------

Update this cell to only report in the comment which site is to be used for review.

EJFielding commented on 2022-05-23T18:25:49Z ----------------------------------------------------------------

updated

review-notebook-app[bot] commented 2 years ago

View / edit / reply to this conversation on ReviewNB

dbekaert commented on 2022-05-23T04:20:50Z ----------------------------------------------------------------

Line #8.    import pickle

Why is pickle needed?

_EJFielding commented on 2022-05-23T18:25:38Z_ ----------------------------------------------------------------

now removed

review-notebook-app[bot] commented 2 years ago

View / edit / reply to this conversation on ReviewNB

dbekaert commented on 2022-05-23T04:20:51Z ----------------------------------------------------------------

Not sure why pickle is needed.

EJFielding commented on 2022-05-23T18:23:12Z ----------------------------------------------------------------

This was a leftover from Kang's notebook. No longer needed, so I deleted it.

EJFielding commented 2 years ago

This was a leftover from Kang's notebook. No longer needed, so I deleted it.

---

View entire conversation on ReviewNB

EJFielding commented 2 years ago

now removed

---

View entire conversation on ReviewNB

EJFielding commented 2 years ago

updated

---

View entire conversation on ReviewNB

yunjunz commented 2 years ago

Could we drop NISAR_SES_ from the notebook filename as well?

EJFielding commented 2 years ago

@yunjunz David asked me to keep the name the same so that the new version can be easily compared to the old version in ReviewNB.

EJFielding commented 2 years ago

Maybe someone can send another renaming PR after this is merged?

dbekaert commented 2 years ago

Can use the git mv command to rename it to a new name. I think that would still allows for comparision

yunjunz commented 2 years ago

If you recall our video meeting last time, together with Marco, you could also use right click --> rename within jupyter to do this, similar to git mv. Both will allow the comparison.

EJFielding commented 2 years ago

I renamed both the Coseismic and Secular notebooks. I used git mv which works for GitHub, but seems to confuse ReviewNB. Anyway, it is no longer important to compare to the old Secular notebook.

review-notebook-app[bot] commented 2 years ago

View / edit / reply to this conversation on ReviewNB

yunjunz commented on 2022-05-23T22:18:20Z ----------------------------------------------------------------

Line #5.    site='MojaveD173'  

Not a big deal. But if we use site_name here, then we could run site = sites[site_name] once and use site instead of sites[site] for the rest of the notebook.

The rest of the PR looks great.

review-notebook-app[bot] commented 2 years ago

View / edit / reply to this conversation on ReviewNB

yunjunz commented on 2022-05-23T23:32:12Z ----------------------------------------------------------------

We should ues Tides instead of Tide as we correct for all the tidal components. You might want to ensure this throughout the notebook.

EJFielding commented 2 years ago

The last commit by @nabolfat was some heading and table of contents updates for the Coseismic notebook.

• © Githubissues.
• Githubissues is a development platform for aggregating issues.

[review-notebook-app[bot]]

View / edit / reply to this conversation on ReviewNB

dbekaert commented on 2022-05-23T04:20:50Z ----------------------------------------------------------------

Line #8.    import pickle

Why is pickle needed?

_EJFielding commented on 2022-05-23T18:25:38Z_ ----------------------------------------------------------------

now removed

review-notebook-app[bot] commented 2 years ago

View / edit / reply to this conversation on ReviewNB

dbekaert commented on 2022-05-23T04:20:51Z ----------------------------------------------------------------

Not sure why pickle is needed.

EJFielding commented on 2022-05-23T18:23:12Z ----------------------------------------------------------------

This was a leftover from Kang's notebook. No longer needed, so I deleted it.

EJFielding commented 2 years ago

This was a leftover from Kang's notebook. No longer needed, so I deleted it.

---

View entire conversation on ReviewNB

EJFielding commented 2 years ago

now removed

---

View entire conversation on ReviewNB

EJFielding commented 2 years ago

updated

---

View entire conversation on ReviewNB

yunjunz commented 2 years ago

Could we drop NISAR_SES_ from the notebook filename as well?

EJFielding commented 2 years ago

@yunjunz David asked me to keep the name the same so that the new version can be easily compared to the old version in ReviewNB.

EJFielding commented 2 years ago

Maybe someone can send another renaming PR after this is merged?

dbekaert commented 2 years ago

Can use the git mv command to rename it to a new name. I think that would still allows for comparision

yunjunz commented 2 years ago

If you recall our video meeting last time, together with Marco, you could also use right click --> rename within jupyter to do this, similar to git mv. Both will allow the comparison.

EJFielding commented 2 years ago

I renamed both the Coseismic and Secular notebooks. I used git mv which works for GitHub, but seems to confuse ReviewNB. Anyway, it is no longer important to compare to the old Secular notebook.

review-notebook-app[bot] commented 2 years ago

View / edit / reply to this conversation on ReviewNB

yunjunz commented on 2022-05-23T22:18:20Z ----------------------------------------------------------------

Line #5.    site='MojaveD173'  

Not a big deal. But if we use site_name here, then we could run site = sites[site_name] once and use site instead of sites[site] for the rest of the notebook.

The rest of the PR looks great.

review-notebook-app[bot] commented 2 years ago

View / edit / reply to this conversation on ReviewNB

yunjunz commented on 2022-05-23T23:32:12Z ----------------------------------------------------------------

We should ues Tides instead of Tide as we correct for all the tidal components. You might want to ensure this throughout the notebook.

EJFielding commented 2 years ago

The last commit by @nabolfat was some heading and table of contents updates for the Coseismic notebook.

• © Githubissues.
• Githubissues is a development platform for aggregating issues.

[review-notebook-app[bot]]

View / edit / reply to this conversation on ReviewNB

dbekaert commented on 2022-05-23T04:20:51Z ----------------------------------------------------------------

Not sure why pickle is needed.

EJFielding commented on 2022-05-23T18:23:12Z ----------------------------------------------------------------

This was a leftover from Kang's notebook. No longer needed, so I deleted it.

EJFielding commented 2 years ago

This was a leftover from Kang's notebook. No longer needed, so I deleted it.

---

View entire conversation on ReviewNB

EJFielding commented 2 years ago

now removed

---

View entire conversation on ReviewNB

EJFielding commented 2 years ago

updated

---

View entire conversation on ReviewNB

yunjunz commented 2 years ago

Could we drop NISAR_SES_ from the notebook filename as well?

EJFielding commented 2 years ago

@yunjunz David asked me to keep the name the same so that the new version can be easily compared to the old version in ReviewNB.

EJFielding commented 2 years ago

Maybe someone can send another renaming PR after this is merged?

dbekaert commented 2 years ago

Can use the git mv command to rename it to a new name. I think that would still allows for comparision

yunjunz commented 2 years ago

If you recall our video meeting last time, together with Marco, you could also use right click --> rename within jupyter to do this, similar to git mv. Both will allow the comparison.

EJFielding commented 2 years ago

I renamed both the Coseismic and Secular notebooks. I used git mv which works for GitHub, but seems to confuse ReviewNB. Anyway, it is no longer important to compare to the old Secular notebook.

review-notebook-app[bot] commented 2 years ago

View / edit / reply to this conversation on ReviewNB

yunjunz commented on 2022-05-23T22:18:20Z ----------------------------------------------------------------

Line #5.    site='MojaveD173'  

Not a big deal. But if we use site_name here, then we could run site = sites[site_name] once and use site instead of sites[site] for the rest of the notebook.

The rest of the PR looks great.

review-notebook-app[bot] commented 2 years ago

View / edit / reply to this conversation on ReviewNB

yunjunz commented on 2022-05-23T23:32:12Z ----------------------------------------------------------------

We should ues Tides instead of Tide as we correct for all the tidal components. You might want to ensure this throughout the notebook.

EJFielding commented 2 years ago

The last commit by @nabolfat was some heading and table of contents updates for the Coseismic notebook.

• © Githubissues.
• Githubissues is a development platform for aggregating issues.

[EJFielding]

This was a leftover from Kang's notebook. No longer needed, so I deleted it.

---

View entire conversation on ReviewNB

[EJFielding]

now removed

---

View entire conversation on ReviewNB

[EJFielding]

updated

---

View entire conversation on ReviewNB

[yunjunz]

Could we drop NISAR_SES_ from the notebook filename as well?

[EJFielding]

@yunjunz David asked me to keep the name the same so that the new version can be easily compared to the old version in ReviewNB.

[EJFielding]

Maybe someone can send another renaming PR after this is merged?

[dbekaert]

Can use the git mv command to rename it to a new name. I think that would still allows for comparision

[yunjunz]

If you recall our video meeting last time, together with Marco, you could also use right click --> rename within jupyter to do this, similar to git mv. Both will allow the comparison.

[EJFielding]

I renamed both the Coseismic and Secular notebooks. I used git mv which works for GitHub, but seems to confuse ReviewNB. Anyway, it is no longer important to compare to the old Secular notebook.

[review-notebook-app[bot]]

View / edit / reply to this conversation on ReviewNB

yunjunz commented on 2022-05-23T22:18:20Z ----------------------------------------------------------------

Line #5.    site='MojaveD173'  

Not a big deal. But if we use site_name here, then we could run site = sites[site_name] once and use site instead of sites[site] for the rest of the notebook.

The rest of the PR looks great.

review-notebook-app[bot] commented 2 years ago

View / edit / reply to this conversation on ReviewNB

yunjunz commented on 2022-05-23T23:32:12Z ----------------------------------------------------------------

We should ues Tides instead of Tide as we correct for all the tidal components. You might want to ensure this throughout the notebook.

EJFielding commented 2 years ago

The last commit by @nabolfat was some heading and table of contents updates for the Coseismic notebook.

• © Githubissues.
• Githubissues is a development platform for aggregating issues.

[review-notebook-app[bot]]

View / edit / reply to this conversation on ReviewNB

yunjunz commented on 2022-05-23T23:32:12Z ----------------------------------------------------------------

We should ues Tides instead of Tide as we correct for all the tidal components. You might want to ensure this throughout the notebook.

EJFielding commented 2 years ago

The last commit by @nabolfat was some heading and table of contents updates for the Coseismic notebook.

• © Githubissues.
• Githubissues is a development platform for aggregating issues.

[EJFielding]

The last commit by @nabolfat was some heading and table of contents updates for the Coseismic notebook.