search

nisar-solid / ATBD

Notebooks for NISAR Solid Earth Algorithm Theoretical Basis Document
35 stars 22 forks source link

Coseismic: modified to better use staged data #33

Closed EJFielding closed 2 years ago

EJFielding commented 2 years ago

Modified Coseismic notebook to reuse the MintPy configuration file included with staged data (same as was done in Secular notebook) so that MintPy will skip the network inversion that takes a long time on "nisar-calval" virtual machines

review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

review-notebook-app[bot] commented 2 years ago

View / edit / reply to this conversation on ReviewNB

dbekaert commented on 2022-06-02T14:58:24Z ----------------------------------------------------------------

Line #5.    config_file = Path(mintpy_dir)/(sites[site]['calval_location'] + '_Sen.txt')

Lets stay consistent between notebooks on use of txt of cfg


_EJFielding commented on 2022-06-02T15:19:41Z_ ----------------------------------------------------------------

The present version of the staged dataset for RidgecrestA64 includes the configuration file named Ridgecrest_Sen.txt. I was trying to avoid recreating the staged data with the different configuration file name.

_yunjunz commented on 2022-06-02T17:44:59Z_ ----------------------------------------------------------------

mintpy should not care about the file name of the custom config file, it only check its content. The effective change here is the mintpy.network.excludeIfgIndex , so no need for filename change.

EJFielding commented 2 years ago

The present version of the staged dataset for RidgecrestA64 includes the configuration file named Ridgecrest_Sen.txt. I was trying to avoid recreating the staged data with the different configuration file name.

View entire conversation on ReviewNB

yunjunz commented 2 years ago

mintpy should not care about the file name of the custom config file, it only check its content. The effective change here is the mintpy.network.excludeIfgIndex , so no need for filename change.

View entire conversation on ReviewNB

dbekaert commented 2 years ago

I think this PR is now replaced with PR #35 @EJFielding @nabolfat ?

nabolfat commented 2 years ago

Yes, PR#35 is addressing the same issue. I added an if condition so it is recognized that the Ridgecrest config-file name is different from other staged data.

dbekaert commented 2 years ago

Per comment of @nabolfat, closing this here

  • © Githubissues.
  • Githubissues is a development platform for aggregating issues.