nischayn22 / PageQuality

A MediaWiki extension to monitor and improve Page Quality
MIT License
0 stars 1 forks source link

the blocked_expressions list somehow gets erased again and again #15

Closed drorsnir closed 2 years ago

drorsnir commented 2 years ago

Trying to reproduce it, it seems like saving anything in the general tab resets the readability tab (but not the other way around).

Another issue is that you can make a change in one tab, switch to another and then save - only the changes in the current tab will be saved, even though there was no warning. I think your code should probably consider all the tabs as one form .

drorsnir commented 2 years ago

Actually, saving any tab will cause the settings of other tabs to be erased (except for the general tab, which retains its settings).

nischayn22 commented 2 years ago

Fixed in https://github.com/nischayn22/PageQuality/commit/301c28c76fb1726d6abfd8545bba33507eea8057

drorsnir commented 2 years ago

Great