nischcodes / homebridge-wiz-net

Control Wiz products over network.
MIT License
4 stars 1 forks source link

Bulbs are not identified #1

Closed Mobidick1112 closed 1 year ago

Mobidick1112 commented 1 year ago

Wiz bulbs are not identified, when with the version "Wiz Lan" from "kpsuperplane" they are. The plugs ESP25 are well identified with your version, but that is not the cas for version "Wiz Lan". A mix of both would be great, but I don't know how to do it.

nischcodes commented 1 year ago

Sorry @Mobidick1112 for your inconveniences. This project isn‘t a real fork of the „kpsuperplane“ version, so there is no back porting of any modifications by me. This project was a weekend hack without any intentions to really work on this project actively.

If you only want to use my version in conjunction to the „kpsuperplane“ version comment out the hole line 3 of the file /accessories/index.ts and delete the „socket“ variable in line 6 of the same file. Than my code only supports the „ESP_25“ sockets.

Oh and don’t forget to change the default port in the configurations. Both plugins uses the same port for communication. And so you have to make sure that both have a dedicated port.

Hope that helps you a bit.

Mobidick1112 commented 1 year ago

Tanks for quick response. The idea to modify the file is a good idea, but I’m not able to save the new version of the file.

Regards

Le 8 janv. 2023 à 13:17, Nikolas Schwarz @.***> a écrit :

Sorry @Mobidick1112 https://github.com/Mobidick1112 for your inconveniences. This project isn‘t a real fork of the „kpsuperplane“ version, so there is no back porting of any modifications by me. This project was a weekend hack without any intentions to really work on this project actively.

If you only want to use my version in conjunction to the „kpsuperplane“ version comment out the hole line 3 of the file /accessories/index.ts and delete the „socket“ variable in line 6 of the same file. Than my code only supports the „ESP_25“ sockets.

Oh and don’t forget to change the default port in the configurations. Both plugins uses the same port for communication. And so you have to make sure that both have a dedicated port.

Hope that helps you a bit.

— Reply to this email directly, view it on GitHub https://github.com/nikolas-schwarz/homebridge-wiz-net/issues/1#issuecomment-1374822346, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5EK6DUXPC2UTN2USVAX5T3WRKV43ANCNFSM6AAAAAATUQYLNU. You are receiving this because you were mentioned.

nischcodes commented 1 year ago

If you have modified the files on you computer, you have to run the build command specified in the package.json because node can’t run typescript files. In order to run the build command you must have node.js installed and also the development dependencies (use the npm -i command). This will install esbuild and all the other libraries. After you have successfully run the build command you can replace the js file in the dist folder of your homebridge plugin.

if you have trouble or you are new to this kind of development, with your request I had the idea to add configuration fields for plug und socket, so that you can enable and disable them without any modifications on my code. Today I am busy with some other projects, but I am planing to add this new feature next week. If you want to wait.

Another open Task is an update of the plug-in in general, because the current implementation isn’t best practice recommended by the homebridge project.

Mobidick1112 commented 1 year ago

Thanks for your help, but it becomes to complex for me. I prefer wait a new version when you have time to do it. Don’t worry it’s already very interesting to have this kind of discussion, that just show nothing is very easy.

Nice day

Dominique

Le 8 janv. 2023 à 20:24, Nikolas Schwarz @.***> a écrit :

If you have modified the files on you computer, you have to run the build command specified in the package.json because node can’t run typescript files. In order to run the build command you must have node.js installed and also the development dependencies (use the npm -i command). This will install esbuild and all the other libraries. After you have successfully run the build command you can replace the js file in the dist folder of your homebridge plugin.

if you have trouble or you are new to this kind of development, with your request I had the idea to add configuration fields for plug und socket, so that you can enable and disable them without any modifications on my code. Today I am busy with some other projects, but I am planing to add this new feature next week. If you want to wait.

Another open Task is an update of the plug-in in general, because the current implementation isn’t best practice recommended by the homebridge project.

— Reply to this email directly, view it on GitHub https://github.com/nikolas-schwarz/homebridge-wiz-net/issues/1#issuecomment-1374908717, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5EK6DVM6GFRG7DTE32NVIDWRMH73ANCNFSM6AAAAAATUQYLNU. You are receiving this because you were mentioned.

Mobidick1112 commented 1 year ago

Hello,

The problem was finally solved by the owner of the original plugin.

Thanks for your help and nice day

Dominique

Le 9 janv. 2023 à 09:09, Mobidick 1112 @.***> a écrit :

Thanks for your help, but it becomes to complex for me. I prefer wait a new version when you have time to do it. Don’t worry it’s already very interesting to have this kind of discussion, that just show nothing is very easy.

Nice day

Dominique

Le 8 janv. 2023 à 20:24, Nikolas Schwarz @.***> a écrit :

If you have modified the files on you computer, you have to run the build command specified in the package.json because node can’t run typescript files. In order to run the build command you must have node.js installed and also the development dependencies (use the npm -i command). This will install esbuild and all the other libraries. After you have successfully run the build command you can replace the js file in the dist folder of your homebridge plugin.

if you have trouble or you are new to this kind of development, with your request I had the idea to add configuration fields for plug und socket, so that you can enable and disable them without any modifications on my code. Today I am busy with some other projects, but I am planing to add this new feature next week. If you want to wait.

Another open Task is an update of the plug-in in general, because the current implementation isn’t best practice recommended by the homebridge project.

— Reply to this email directly, view it on GitHub https://github.com/nikolas-schwarz/homebridge-wiz-net/issues/1#issuecomment-1374908717, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5EK6DVM6GFRG7DTE32NVIDWRMH73ANCNFSM6AAAAAATUQYLNU. You are receiving this because you were mentioned.