Video stream stays on when MM is shut down

nischi / MMM-Face-Reco-DNN

Face recognition with opencv and deep neural network

MIT License

91 stars 46 forks source link

Video stream stays on when MM is shut down #20

Closed hknozturk closed 4 years ago

hknozturk commented 4 years ago

Importing VideoStream from imutils fixes the bug. However, it started to give 'FATAL: exception not rethrown'. Also, 'vs.stop()' is enough to shut is down the video stream (no need an if condition as suggested in the discussion.)

nischi commented 4 years ago

@hknozturk, thanks a lot for the pull request.

Is this working for PiCam and a normal Webcam? Or does it only works with a normal webcam?

hknozturk commented 4 years ago

I couldn't make a fish-eye camera work on pi3. That's why I could only test with the webcam. If I manage fish-eye to work, I will test this PR properly and let you know.

nischi commented 4 years ago

okay then i need to test that first. thanks for your reply.

nischi commented 4 years ago

Assign Issue #7

nischi commented 4 years ago

@AlphaMycelium Awesome, thanks.