nishaaannnt / advance-bookmarks

A chrome extension to manage and arrange your bookmarks in a better way.
20 stars 8 forks source link

[Bug] When The User Deletes or Adds a bookmark in the browser it doesn't update in the extension. #11

Closed ArkadiK94 closed 1 year ago

ArkadiK94 commented 1 year ago

Describe the bug

When The User Deletes or Adds a bookmark in the browser it doesn't update in the app extension.

To Reproduce

Add/Delete a new bookmark Open the extension

Expected Behavior

It should be updated automatically

Screenshot/ Video

https://github.com/nishaaannnt/advance-bookmarks/assets/76536506/539fadb1-66c0-4462-a328-68c066914a8f

nishaaannnt commented 1 year ago

go for it @ArkadiK94

nishaaannnt commented 1 year ago

hey @ArkadiK94 I thought the code would work fine and merged as it seemed all good but there is an issue that when i open the extension none bookmarks are visible. Please check.

ArkadiK94 commented 1 year ago

Very strange, it works for me without a problem. Did you create new build in vs code? Did you refresh the extension in chrome://extensions ? Could you send images/short video? Could you click "inspect" from the extension and from service_worker to see if there are errors in the console?

https://github.com/nishaaannnt/advance-bookmarks/assets/76536506/53f18626-8d08-41c7-a037-24c77a14aee0

ArkadiK94 commented 1 year ago

In addition, for another issue, we need to add a message to user when there was not added any bookmark yet.

ArkadiK94 commented 1 year ago

@nishaaannnt

nishaaannnt commented 1 year ago

@ArkadiK94 Sorry I was a bit busy this week. I will recheck and get back

nishaaannnt commented 1 year ago

@ArkadiK94 Hey Sorry, Actually i forgot to refresh the extension in hurry last time. Code works fine everything looks good.

Also can you please raise a PR again as I can just checkout and merge the branch myself but i dont want your hacktober-fest label to be taken away from you. Thank you for your contributions! @ArkadiK94

ArkadiK94 commented 1 year ago

@nishaaannnt It is ok, I already got enough pr's for the hacktoberfest event. Could you just merge the branch?

ArkadiK94 commented 1 year ago

@nishaaannnt Pls, tell me if you need me to open a new pr because of the revert, so I will do it :)

nishaaannnt commented 1 year ago

@ArkadiK94 hello, yeah man please. i ran into some issues and too tired to resolve it lol

ArkadiK94 commented 1 year ago

@nishaaannnt Hi, it is fine :) I created new pr as the previous one.

ArkadiK94 commented 1 year ago

@nishaaannnt Hi, I close this issue because I saw that you merged the pr.