search

nishaaannnt / advance-bookmarks

A chrome extension to manage and arrange your bookmarks in a better way.
20 stars 8 forks source link

[Feature] Toggle between dark and light mode #7

Closed nishaaannnt closed 1 year ago

nishaaannnt commented 1 year ago

A button in info section of extension to toggle between light and dark mode for extension.

tara-matthew commented 1 year ago

Hey, could I work on this please?

nishaaannnt commented 1 year ago

go for it @tara-matthew. but please make a new branch and then raise a PR. Start working on it .

GD0910 commented 1 year ago

@nishaaannnt can i work on this feature as well

nishaaannnt commented 1 year ago

@GD0910 i will wait till tomorrow for the PR. If none occurs i will assign the issue to you

GD0910 commented 1 year ago

hi @nishaaannnt can i work on this feature now ?

nishaaannnt commented 1 year ago

@GD0910 please fork and make a new branch and make necessary changes. Thank you

GD0910 commented 1 year ago

Hi @nishaaannnt I have implemented dark mode toggle function image

image and This is how it looks in light mode if any changes to be made please infom me the necessary changes and i wll try to complete that issue

This is my first contribution in open source .Your suggestions would be valuable

nishaaannnt commented 1 year ago

@GD0910 can you show me both dark and light mode images?

GD0910 commented 1 year ago

@GD0910 can you show me both dark and light mode images?

sure

GD0910 commented 1 year ago

extra : I changed 3-dot icon as in previous icon there wasn't spacing between the dots

https://github.com/nishaaannnt/advance-bookmarks/assets/88530462/a2181089-ae79-4d5a-b5c8-538d657a84a1

nishaaannnt commented 1 year ago

@GD0910 recommendations -

  1. Add the toggle button in about page . maybe on the right side of buy me a coffee.
  2. The dark mode color seems to be changed then the standard dark theme of extension. please keep the same default dark color theme.

Rest looks good to me. If you can do above changes let me know. Thank you

GD0910 commented 1 year ago

@GD0910 recommendations -

  1. Add the toggle button in about page . maybe on the right side of buy me a coffee.
  2. The dark mode color seems to be changed then the standard dark theme of extension. please keep the same default dark color theme.

Rest looks good to me. If you can do above changes let me know. Thank you

i will reset the dark mode color theme About the toggle button : It will be better if we place it in main page rather than in about section as it will be easy to use and not everyone will open the about section

GD0910 commented 1 year ago

image I have switched to the original colors for dark theme