Closed ghost closed 3 years ago
@nishanths, thanks for you review, I've made some updates to address your requested changes. I hope it looks good now :)
Thank you for the changes.
I see two build errors at the moment on the branch. Could you fix them, please?
% go build
# github.com/nishanths/license/v5
./license.go:36:10: undefined: apppend
./license.go:47:11: assignment mismatch: 2 variables but 1 values
And my apologies for not having an automatic CI check present. I will set that up for this repository after we merge this PR.
No worries, I'll have that fixed up in a second.
And my apologies for not having an automatic CI check present. I will set that up for this repository after we merge this PR.
That was actually going to be my next contribution, if you want I can set this up.
That was actually going to be my next contribution, if you want I can set this up.
Yes, please feel free to. And thank you again.
Alrighty, @nishanths, we should be good to go 🤞
Merged :)
This replace go-bindata with the native embed directive.
Closes nishanths#29 Closes yuri-norwood#2