search

nishanths / license

Command line license text generator.
MIT License
663 stars 82 forks source link

adjust `Go / fmt (pull_request)` check #43

Closed nishanths closed 2 years ago

nishanths commented 2 years ago

Firstly, the check auto-formats and auto-commits changes to branches. This is behavior I tend to not like. We should modify the check to only check that the code is formatted. It should not auto-commit any changes.

Secondly, it seems to fail when run on a PR for branches on other remotes. For example, see this run.

norwd commented 2 years ago

@nishanths, instead of using stefanzweifel/git-auto-commit-action, maybe the workflow could use reviewdog/action-suggester to suggest the go fmt changes instead of just committing them directly?

nishanths commented 2 years ago

@norwd: Replied in the pull request.

nishanths commented 2 years ago

Fixed in #46.