nishantmc / angular-zoom

A angular zoom library for images based on zoom.js
MIT License
16 stars 4 forks source link

Have Error when build #1

Open ppjjzz opened 6 years ago

ppjjzz commented 6 years ago

When I build my application, i got the error like these: ERROR in : Unexpected value 'ZoomModule in D:/bang-ng-template/node_modules/angular-zoom/zoom.module.d.ts' imported by the module 'ShareModule in D:/bang-ng-template/src/app/share/share.module.ts'. Please add a @NgModule annotation.

Pls fix this bug

nishantmc commented 6 years ago

Hi, Thanks for trying out the package. I assume you are using the latest version. Can you please let me know the angular version you are using?

ppjjzz commented 6 years ago

Angular CLI: 1.7.0 Node: 8.9.4 OS: win32 x64 Angular: 5.2.5

nishantmc commented 6 years ago

I was testing the package with a angular + webpack starter kit (https://github.com/nishantmc/angular-webpack-starter) with the following deps

"dependencies": {
  "@angular/common": "5.2.5",
  "@angular/compiler": "5.2.5",
  "@angular/core": "5.2.5",
  "angular-zoom": "0.0.5",

  "@angular/platform-browser": "5.2.5",
  "@angular/platform-browser-dynamic": "5.2.5",
  "core-js": "^2.4.1",
  "rxjs": "5.0.1",
  "zone.js": "^0.8.4"
},

I could test the demo page without any issues. I was using webpack to build the project. How are you building the project? Can you also send me all the deps so that i can try locally?

ppjjzz commented 6 years ago

I build my project with angular-cli 1.7.0 with following deps

"dependencies": {
    "@angular/animations": "^5.2.0",
    "@angular/common": "^5.2.0",
    "@angular/compiler": "^5.2.0",
    "@angular/core": "^5.2.0",
    "@angular/forms": "^5.2.0",
    "@angular/http": "^5.2.0",
    "@angular/platform-browser": "^5.2.0",
    "@angular/platform-browser-dynamic": "^5.2.0",
    "@angular/router": "^5.2.0",
    "@angular/service-worker": "^5.2.5",
    "angular-zoom": "0.0.5",
    "bootstrap": "^3.3.7",
    "core-js": "^2.4.1",
    "jquery": "^3.3.1",
    "ng-click-outside": "^3.2.0",
    "ng-zorro-antd": "^0.6.11",
    "rxjs": "^5.5.6",
    "web-storage-cache": "^1.0.3",
    "zone.js": "^0.8.19"
  },
  "devDependencies": {
    "@angular/cli": "^1.7.0",
    "@angular/compiler-cli": "^5.2.0",
    "@angular/language-service": "^5.2.0",
    "@types/jasmine": "~2.8.3",
    "@types/jasminewd2": "~2.0.2",
    "@types/node": "~6.0.60",
    "codelyzer": "^4.0.1",
    "jasmine-core": "~2.8.0",
    "jasmine-spec-reporter": "~4.2.1",
    "karma": "~2.0.0",
    "karma-chrome-launcher": "~2.2.0",
    "karma-coverage-istanbul-reporter": "^1.2.1",
    "karma-jasmine": "~1.1.0",
    "karma-jasmine-html-reporter": "^0.2.2",
    "protractor": "~5.1.2",
    "ts-node": "~4.1.0",
    "tslint": "~5.9.1",
    "typescript": "~2.6.0"
  }
mathisGarberg commented 6 years ago

Same issue here.

minahmoghadam commented 6 years ago

I have the same issue :(

akshay575 commented 6 years ago

Works fine on development, but throws up this error when taking a build: ERROR in : Unexpected value 'ZoomModule in F:/AppName/node_modules/angular-zoom/zoom.module.d.ts' imported by the module 'AppModule in F:/AppName/src/app/app.module.ts'. Please add a @NgModule annotation.

dannygoncalves commented 3 years ago

Necro, but same error here and this package has the functionality I need, to sad to see it's not maintained.