search

nishidhaSri / spacestagram

0 stars 3 forks source link

Generate shareable links #1

Closed nishidhaSri closed 3 years ago

nishidhaSri commented 3 years ago
arvind-1 commented 3 years ago

@nishidhaSri Can I work on this? or you suggest

nishidhaSri commented 3 years ago

Sure, @arvind-1 go ahead and give it a try.

arvind-1 commented 3 years ago

@nishidhaSri could you assign this to me?

arvind-1 commented 3 years ago

I have few questions.

  1. As we are fetching this directly from NASA API we don't have our id for each image. what do we do about it?
  2. If user access the shared link how do they view that image as a single image with comments or description about it?
  3. Should we maintain our own database?
nishidhaSri commented 3 years ago

Regarding your query:

  1. Every image have a unique URL, so we can differentiate using that
  2. This I am leaving it to your creativity, you can either create new route for each APOD image where more detail information like description is shown and this route can be shared or just provide a way where user can directly share the image url. Ultimate goal is to share the image.
  3. This project is created to enhance frontend skills, lets consider using databases or writing apis as a last resort.
arvind-1 commented 3 years ago

About every image having a unique URL, they are for API right or our APP?

nishidhaSri commented 3 years ago

I mean the source url of the image which is received in every object of APOD

arvind-1 commented 3 years ago

Yes, but how do fetch that image from share? there is no unique identifier for that image apart from the URL. So we have to make our own indexing for these images. For example, if we have a sharable URL as https://spacestagram/img/1345 with this URL we need to scrap image from API and we don't have any APIs to fetch data.

nishidhaSri commented 3 years ago

APOD have a unique date for every image, go through the queries accepted by API used, you can fetch APOD by date

kailash360 commented 3 years ago

Can I work on this issue?

nishidhaSri commented 3 years ago

sure @kailash360

kailash360 commented 3 years ago

@nishidhaSri, I have created the PR #10 for this issue.

nishidhaSri commented 3 years ago

Do create a PR to development branch

kailash360 commented 3 years ago

@nishidhaSri, I have now a created PR #12 in the development branch.