Closed kanta1207 closed 7 months ago
@kanta1207 Thank you for the implementation! Please kindly check the comments I left.
@uskayyyyy Thank you for your review! I addressed the points you brought up. Please take a relook at them 🙏
I thought this PR's scope is a little bit small, but it's good to go. Thanks!
@kotaaaa Yeah indeed maybe I tried to make it too small 😅
I'll just replace form
with Form
component quickly in next PR
Overview
Related issue : #181
Implement
createGroup
api client, which works in client componentInvoke
createGroup
method insrc/features/groups/components/CreateGroupButton/CreateGroupDrawerContent.tsx
with pure htmlform
tag for now.Changes
Add
createGroup
method tosrc/lib/api/group/client/groupApiClient.client.ts
Add html
<form>
tag tosrc/features/groups/components/CreateGroupButton/CreateGroupDrawerContent.tsx
Invoke
createGroup
insrc/features/groups/components/CreateGroupButton/CreateGroupDrawerContent.tsx
What I didn't in this PR
I will tackle on Implementation of
CreateGroupForm
component in next scope, using commonForm
component and react-hook-form. In this PR, I only focused on the API call.Review points
createGroup
method properly implemented with its testAssignee Checklist:
Reviewer Checklist: