Closed kanta1207 closed 9 months ago
@kotaaaa Thank you for the quick review!!
@uskayyyyy Thank you for the good call outs! I modified all of them, since I mostly agreed with all of the points you mentioned! Please take a relook at my code and comment on your convenience! Thx 🙌
@kanta1207
Could you check my replies, please? You missed them and merged 😂
Overview
Create Checkbox component based on shadcn Checkbox
Changes
Checkbox.tsx
tosrc/components/ui
directory.CheckboxUsageExample.tsx
Checkbox
insrc/components/ui/index.ts
icon_check.svg
toassets/images/icons
white
to Icon component variantReview points
className
tho. Should I make size variant already, considering the desktop design?Screen Captures
https://github.com/genesis-tech-tribe/nishiki-frontend/assets/99339182/31220b71-7c09-4270-8b37-13f8834e5fdb
References
Assignee Checklist:
Reviewer Checklist: