nishiki-tech / nishiki-frontend

Nishiki is an app for tracking and sharing food inventories within groups for better pantry management.
https://nishiki.tech
MIT License
20 stars 5 forks source link

Feat : Create DropdownMenu shared UI component #210

Closed kanta1207 closed 7 months ago

kanta1207 commented 7 months ago

Overview

Changes

-

Review points

Screen Captures

https://github.com/genesis-tech-tribe/nishiki-frontend/assets/99339182/d0fe3d67-c180-411b-8703-2b46800ef4d7

References

Assignee Checklist:

Reviewer Checklist:

kanta1207 commented 7 months ago

@uskayyyyy Thank you for concise review as always! I solved the problems you mentioned, and reacted with 🚀 on your comments.

Please kindly take a look at the replies I left and also the comment I left on src/components/ui/DropdownMenuUsageExample.tsx file, and appreciated if you can share your thoughts on them 🙏

kanta1207 commented 7 months ago

@uskayyyyy I updated the things listed below!

File changes got bigger, so please take your time and review them again anytime you can!

kanta1207 commented 7 months ago

Also, the following checks of the checklist seem to be missed...

  • The naming convention of the PR title is correct (See the comment at the top of this template)
  • All the related issues are associated with this PR

I associated the issue, and sorry about the branch naming convention ... I'll try not to make the same mistake in the next working branch

kanta1207 commented 7 months ago

@nick-y-ito Thank you for helping me out, again! I resolved the points you mentioned in the latest commits, and tick the checkboxes in the issue! Please take a relook, and kindly share any concern 🙏