Closed kanta1207 closed 7 months ago
@uskayyyyy Thank you for concise review as always! I solved the problems you mentioned, and reacted with 🚀 on your comments.
Please kindly take a look at the replies I left and also the comment I left on src/components/ui/DropdownMenuUsageExample.tsx
file, and appreciated if you can share your thoughts on them 🙏
@uskayyyyy I updated the things listed below!
File changes got bigger, so please take your time and review them again anytime you can!
Also, the following checks of the checklist seem to be missed...
- The naming convention of the PR title is correct (See the comment at the top of this template)
- All the related issues are associated with this PR
I associated the issue, and sorry about the branch naming convention ... I'll try not to make the same mistake in the next working branch
@nick-y-ito Thank you for helping me out, again! I resolved the points you mentioned in the latest commits, and tick the checkboxes in the issue! Please take a relook, and kindly share any concern 🙏
Overview
DropdownMenu
component based on shadcnUI dropdown menu component, resolving the issue #192Changes
DropdownMenu
component.menu-kebab
icon.DropdownMenuUsageExample
, implement modifiedGroupCard
in there-
Review points
DropdownComponent
properly implemented?GroupCard
with kebab icon button properly implemented?Screen Captures
https://github.com/genesis-tech-tribe/nishiki-frontend/assets/99339182/d0fe3d67-c180-411b-8703-2b46800ef4d7
References
Assignee Checklist:
Reviewer Checklist: