Feat: Create `RenameGroupForm`

kanta1207 commented 6 months ago

Overview

Create RenameGroupForm component, except for api client

Changes

Create GroupCardContent component separately from GroupCard component
Create RenameGroupForm component
Added icon_circle-cross to implement square text input

Review points

The number of file changes seems big, but most of them are because the directory structure has changed. So please focus the review on RenameGroupForm.

Screen Captures

https://github.com/nishiki-tech/nishiki-frontend/assets/99339182/4db5dfca-9125-47ce-8794-2db764c87b88

Assignee Checklist:

[x] The naming convention of the PR title is correct (See the comment at the top of this template)
[x] The base branch is correct (See: Types of Branches)
[x] The branch name follows the Branch Naming Conventions
[x] The correct assignees and reviewers have been designated for this PR
[x] The coding style follows the Coding Style Guide
[x] All the related issues are associated with this PR
[x] All criteria in the associated issues are met (please tick the checkboxes)
[x] My changes do not generate new warnings or errors (especially in the console)

Reviewer Checklist:

[x] Double-check the "Assignee Checklist"
[x] The code follows the generic best practices and our Coding Style Guide
[x] The code is well-commented and easy to understand
[x] The UI changes accurately reflect the provided design

kanta1207 commented 6 months ago

@kanta1207 Thank you for your excellent work! It was so hard. It also took me quite long to understand the code and underlying issues.

I left several comments on the work. While some of them may be minor and can be dismissed, others may be quite important and require your attention. Additionally, I wanted to bring your attention to a UI problem that I have stated below.

[ ] Rename input does not accurately reflect the given design. Please take a look at the images below.

Current looking

Given design

@nick-y-ito Thank you for the review! Following your review, I addressed the issues and reacted with 🚀 on the ones I resolved! I'll leave some comments on the files I changed for the 2nd round review, so please refer them and take a look at the PR again 🙏

nick-y-ito commented 6 months ago

@kanta1207 Thank you for your excellent update! Overall, it works so well😃 As we talked earlier verbally, let's tackle the remaining two problems.

[ ] The issue that pressing [ enter ] triggers the cross button click
[ ] Refactoring the outside click logic creating a custom hook (https://github.com/nishiki-tech/nishiki-frontend/pull/223#discussion_r1488202117)

Other than those, I believe that this pull request will be perfect and ready to be merged. Thanks again for all your hard work!

kanta1207 commented 6 months ago

@nick-y-ito Thank you for your review! I fixed and refactored the issues we discussed!

[ ] The issue that pressing [ enter ] triggers the cross button click

[ ] Refactoring the outside click logic creating a custom hook ([Feat: Create RenameGroupForm #223 (comment)]

I will leave some comments on the code as well, so please kindly take a look again 🙏

kanta1207 commented 6 months ago

@kanta1207 Thank you so much for your excellent update! I've just left some comments on tiny matters; if you'd like to address them, please feel free to do so. However, this PR already looks absolutely good to go 😄

@nick-y-ito Thank you for your detailed review throughout this PR! I addressed the issues you mentioned, and I'll merge this PR now~ 👍

nishiki-tech / nishiki-frontend