Closed kanta1207 closed 6 months ago
@kanta1207 Thank you for your excellent work! It was so hard. It also took me quite long to understand the code and underlying issues.
I left several comments on the work. While some of them may be minor and can be dismissed, others may be quite important and require your attention. Additionally, I wanted to bring your attention to a UI problem that I have stated below.
- [ ] Rename input does not accurately reflect the given design. Please take a look at the images below.
Current looking
Given design
@nick-y-ito Thank you for the review! Following your review, I addressed the issues and reacted with π on the ones I resolved! I'll leave some comments on the files I changed for the 2nd round review, so please refer them and take a look at the PR again π
@kanta1207 Thank you for your excellent update! Overall, it works so wellπ As we talked earlier verbally, let's tackle the remaining two problems.
Other than those, I believe that this pull request will be perfect and ready to be merged. Thanks again for all your hard work!
@nick-y-ito Thank you for your review! I fixed and refactored the issues we discussed!
- [ ] The issue that pressing [ enter ] triggers the cross button click
- [ ] Refactoring the outside click logic creating a custom hook ([Feat: Create
RenameGroupForm
Β #223 (comment)]
I will leave some comments on the code as well, so please kindly take a look again π
@kanta1207 Thank you so much for your excellent update! I've just left some comments on tiny matters; if you'd like to address them, please feel free to do so. However, this PR already looks absolutely good to go π
@nick-y-ito Thank you for your detailed review throughout this PR! I addressed the issues you mentioned, and I'll merge this PR now~ π
Overview
RenameGroupForm
component, except for api clientChanges
GroupCardContent
component separately fromGroupCard
componentRenameGroupForm
componenticon_circle-cross
to implement square text inputReview points
RenameGroupForm
.Screen Captures
https://github.com/nishiki-tech/nishiki-frontend/assets/99339182/4db5dfca-9125-47ce-8794-2db764c87b88
Assignee Checklist:
Reviewer Checklist: