nishiki-tech / nishiki-frontend

Nishiki is an app for tracking and sharing food inventories within groups for better pantry management.
https://nishiki.tech
MIT License
20 stars 5 forks source link

Feat: Complete login page implemantation #227

Closed kotaaaa closed 6 months ago

kotaaaa commented 6 months ago

Overview

Changes

Screen Captures

image

References

Next Issue

Assignee Checklist:

Reviewer Checklist:

kotaaaa commented 6 months ago

@nick-y-ito

@kotaaaa

Thank you for your work!! I first checked the behavior of the login and left the two comments below. After resolving these, I will review in codebase.

Issue with a specific Google account

Whenever I try to log in with this Google account nick.yusuke.ito@gmail.com, I get the following error as a redirected URL while I can successfully log in with other gmails. It even happens after clearing the site date on the browser.

http://localhost:3000/login?error_description=PreSignUp+failed+with+error+HTTP+request+failed+with+status+400%3A+Bad+Request.+&state=El78BLaQezH9wyuRiWl1soSt0bXzdFjg&error=invalid_request

Screen.Recording.2024-02-07.at.19.00.37.mov

The unnecessary window

Is it possible to skip this window? I have never seen this on other websites before. The behavior I am most familiar with is that right after clicking the login button on a website, I see the Google account selection page.

image

Can you check again about the Issue with a specific Google account? In my environment, it seems resolved.

The unnecessary window

I replaced Cognito hosted UI with <Authenticator socialProviders={['google']} hideSignUp={true} />;. So can you check it?

kanta1207 commented 6 months ago

It seems to be working fine in my environment, so I approved the changes.

@kotaaaa Thank you for your work, while you've been extremely busy!