Closed AnukratiMehta closed 6 months ago
@AnukratiMehta
Additionally, your code does not look formatted correctly. Code formatting is supposed to be performed automatically whenever the git commit
is executed. If you use a GUI git tool, kindly ensure that the git hook path has been configured correctly.
Moreover, kindly confirm that the file .husky/_/husky.sh
exists.
If everything is set up correctly, you should see the message "Preparing lint-staged..." when committing changes.
@nick-y-ito
Thank you so much for the help. The .husky/_/husky.sh
exists and I was able to see "Preparing lint-staged..." when committing changes so everything should work fine now :)
@AnukratiMehta Thank you for updating.
I was wondering if you have access to this Figma design? You will find the Dialog design there, which is used repeatedly throughout the design.
I hope you accurately reflect the design into the code: However, there are still a few remaining issues that need to be addressed:
As you might have already noticed, you can also see the currently implemented "Drawer" by utilizing "src/components/ui/DrawerUsageExample.tsx"
Thank you for your attention to these issues.
@nick-y-ito
Thanks for your patience. I did, in fact, not realize there was a Figma design. I've addressed the two remaining issues. Hope it works now!
Overview
I changed the position of DialogClose from PrimitiveContent to DialogHeader so that it is properly aligned in the center.
Changes
Review points
Screen Captures
Assignee Checklist:
Reviewer Checklist: