nishiki-tech / nishiki-frontend

Nishiki is an app for tracking and sharing food inventories within groups for better pantry management.
https://nishiki.tech
MIT License
20 stars 5 forks source link

Feature: Adjust the position of the close [ x ] button of the Dialog component #234

Closed AnukratiMehta closed 6 months ago

AnukratiMehta commented 6 months ago

Overview

I changed the position of DialogClose from PrimitiveContent to DialogHeader so that it is properly aligned in the center.

Changes

Review points

Screen Captures

Issue 229

Assignee Checklist:

Reviewer Checklist:

nick-y-ito commented 6 months ago

@AnukratiMehta Additionally, your code does not look formatted correctly. Code formatting is supposed to be performed automatically whenever the git commit is executed. If you use a GUI git tool, kindly ensure that the git hook path has been configured correctly.

Moreover, kindly confirm that the file .husky/_/husky.sh exists.

If everything is set up correctly, you should see the message "Preparing lint-staged..." when committing changes.

AnukratiMehta commented 6 months ago

@nick-y-ito Thank you so much for the help. The .husky/_/husky.sh exists and I was able to see "Preparing lint-staged..." when committing changes so everything should work fine now :)

nick-y-ito commented 6 months ago

@AnukratiMehta Thank you for updating.

I was wondering if you have access to this Figma design? You will find the Dialog design there, which is used repeatedly throughout the design.

I hope you accurately reflect the design into the code: However, there are still a few remaining issues that need to be addressed:

As you might have already noticed, you can also see the currently implemented "Drawer" by utilizing "src/components/ui/DrawerUsageExample.tsx"

Thank you for your attention to these issues.

AnukratiMehta commented 6 months ago

@nick-y-ito

Thanks for your patience. I did, in fact, not realize there was a Figma design. I've addressed the two remaining issues. Hope it works now!