Closed nick-y-ito closed 6 months ago
@kanta1207,
Thank you for taking the time to review. I have made the updates below based on your feedback:
request
function for the server. *Please note that I had only made modifications to the one for the client in the previous state.request
functions for both client and server.Please review these changes when you have the time. I hope you also complete the reviewr's checklist.
Thank you!
@kanta1207 Thank you for your review approval 😄
Overview
This PR implements the CRATE & UPDATE food functionalities.
Changes
result-ts-type
that @hitohata created, and utilized it for actions and API client.actions.ts
and added unit testalert()
, which should be replaced with thetoast
request
function for each client/server components to be able to handle empty a response body, for example, in case the status code is 204request
function for each client/server componentsReview points
Screen Captures
https://github.com/nishiki-tech/nishiki-frontend/assets/99148565/b5edc990-bba5-4095-9baf-a5a5ae8f3f4e
References
result-ts-type
that @hitohata createdNotes
-
Assignee Checklist:
Reviewer Checklist: