nishiki-tech / nishiki-frontend

Nishiki is an app for tracking and sharing food inventories within groups for better pantry management.
https://nishiki.tech
MIT License
20 stars 5 forks source link

Feature: Implement food DELETE functionality #246

Closed nick-y-ito closed 6 months ago

nick-y-ito commented 6 months ago

Overview

This PR implements the "delete food dialog" UI and its functionality.

Changes

Non-related changes

Review points

Screen Captures

https://github.com/nishiki-tech/nishiki-frontend/assets/99148565/31c23080-23e2-43dc-b1c0-bf41e0023289

References

Notes

-

Assignee Checklist:

Reviewer Checklist:

nick-y-ito commented 6 months ago

@kanta1207

Thank you for your reviews! Here are the changes that fix the points you mentioned.

In addition, I have also made the following two changes, although these are not directly related to this PR. They are just a minor refactoring and a behavior adjustment.

Before fixing 966d7e0 (#246), the focus moves to the last food card when the edit drawer is closed.

https://github.com/nishiki-tech/nishiki-frontend/assets/99148565/df8bf804-38b1-4107-8ead-7bf5f2f2887a

Please kindly take a moment to review it again :)

nick-y-ito commented 6 months ago

@kanta1207 Thank you for your prompt review and approval, too!