Closed AnukratiMehta closed 6 months ago
@AnukratiMehta
Are you still in progress? If you are done with your change, please re-mention us to ask for a second review.
Currently, some errors are happening in the GitHub Actions. I think they will be solved if you merge the develop
branch.
@nick-y-ito
No, the changes are done. The checks are passing too now. Hope this works!
@AnukratiMehta
Since there was a conflict with the base branch (develop
), I resolved it in the newly created branch feature/127-apply-design-to-SelectContent-resolve-conflict
and also fixed the issues I pointed out in the last comment.
Please utilize it as needed. I think you can merge the branch into yours or cherry-pick the commits.
@AnukratiMehta Since there was a conflict with the base branch (
develop
), I resolved it in the newly created branchfeature/127-apply-design-to-SelectContent-resolve-conflict
and also fixed the issues I pointed out in the last comment.Please utilize it as needed. I think you can merge the branch into yours or cherry-pick the commits.
@nick-y-ito
Thanks. I have some questions. I've messaged you. Could you please check? I think it'll be quicker and easier to address them there :)
Overview
This pull request addresses the issue #127 by updating the
SelectContent
,SelectLabel
, andSelectItem
components to adhere to the design specifications provided in Figma.Changes
CheckIcon
as per the Figma design.Screen Captures
Assignee Checklist:
Reviewer Checklist: