nishiki-tech / nishiki-frontend

Nishiki is an app for tracking and sharing food inventories within groups for better pantry management.
https://nishiki.tech
MIT License
20 stars 5 forks source link

Feature: Apply design changes to Select.tsx #249

Closed AnukratiMehta closed 6 months ago

AnukratiMehta commented 6 months ago

Overview

This pull request addresses the issue #127 by updating the SelectContent, SelectLabel, and SelectItem components to adhere to the design specifications provided in Figma.

Changes

Screen Captures

Screenshot 2024-02-22 at 1 48 29 AM

Assignee Checklist:

Reviewer Checklist:

nick-y-ito commented 6 months ago

@AnukratiMehta

Are you still in progress? If you are done with your change, please re-mention us to ask for a second review.

Currently, some errors are happening in the GitHub Actions. I think they will be solved if you merge the develop branch.

AnukratiMehta commented 6 months ago

@nick-y-ito

No, the changes are done. The checks are passing too now. Hope this works!

nick-y-ito commented 6 months ago

@AnukratiMehta Since there was a conflict with the base branch (develop), I resolved it in the newly created branch feature/127-apply-design-to-SelectContent-resolve-conflict and also fixed the issues I pointed out in the last comment.

Please utilize it as needed. I think you can merge the branch into yours or cherry-pick the commits.

AnukratiMehta commented 6 months ago

@AnukratiMehta Since there was a conflict with the base branch (develop), I resolved it in the newly created branch feature/127-apply-design-to-SelectContent-resolve-conflict and also fixed the issues I pointed out in the last comment.

Please utilize it as needed. I think you can merge the branch into yours or cherry-pick the commits.

@nick-y-ito

Thanks. I have some questions. I've messaged you. Could you please check? I think it'll be quicker and easier to address them there :)